fix: Add RTL support to app heading. #1851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artonge
approved these changes
Nov 25, 2024
artonge
reviewed
Nov 25, 2024
falghamdi125
force-pushed
the
fix-heading-margins-in-rtl-mode
branch
5 times, most recently
from
e54f4cc
to
eb0de2c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1851 +/- ##
=======================================
Coverage 31.36% 31.36%
=======================================
Files 43 43
Lines 1629 1629
Branches 110 110
=======================================
Hits 511 511
Misses 1092 1092
Partials 26 26 ☔ View full report in Codecov by Sentry. |
|
@falghamdi125, sorry, I forgot to ask you to commit and push the build files. |
Signed-off-by: Faisal Alghamdi <falghamdi125@gmail.com>
falghamdi125
force-pushed
the
fix-heading-margins-in-rtl-mode
branch
from
eb0de2c
to
edeb5a4
Compare
|
Build files have been added to the commit @artonge |
|
Thanks a lot @falghamdi125 ! We have a Nextcloud Talk instance where we invite Nextcloud contributors to be able to communicate more quickly. If you like, I could give you a guest account via the email address in your commits? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
Hello everyone,
This PR adjusts app heading margins and adds support for RTL layouts.
🖼️ Screenshots
💡 Note: This pull request is most effective when the Nextcloud-Vue PR:6260 is approved.
Best