Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

putMethod can also be cancelled on user interaction #1061

Merged
merged 2 commits into from
Feb 22, 2023

Conversation

tobiasKaminsky
Copy link
Member

Signed-off-by: tobiasKaminsky tobias@kaminsky.me

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2023

SpotBugs (new)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

SpotBugs (master)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

@codecov
Copy link

codecov bot commented Feb 9, 2023

Codecov Report

Merging #1061 (81e1227) into master (4cf2f75) will increase coverage by 1.61%.
The diff coverage is 20.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1061      +/-   ##
==========================================
+ Coverage   49.35%   50.97%   +1.61%     
==========================================
  Files         179      179              
  Lines        6739     6743       +4     
  Branches      895      897       +2     
==========================================
+ Hits         3326     3437     +111     
+ Misses       2945     2819     -126     
- Partials      468      487      +19     
Impacted Files Coverage Δ
...ources/files/ChunkedFileUploadRemoteOperation.java 74.43% <20.00%> (+48.85%) ⬆️
...om/owncloud/android/lib/common/OwnCloudClient.java 43.42% <0.00%> (+0.57%) ⬆️
...ncloud/android/lib/common/network/WebdavEntry.java 81.25% <0.00%> (+1.56%) ⬆️
...ncloud/android/lib/common/network/WebdavUtils.java 78.99% <0.00%> (+3.36%) ⬆️
...lib/resources/files/UploadFileRemoteOperation.java 58.33% <0.00%> (+6.25%) ⬆️
...mon/network/ChunkFromFileChannelRequestEntity.java 49.18% <0.00%> (+49.18%) ⬆️

surinder-tsys added a commit to surinder-tsys/android-library that referenced this pull request Feb 9, 2023
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2023

SpotBugs (new)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

SpotBugs (master)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

@AlvaroBrey AlvaroBrey merged commit 376c151 into master Feb 22, 2023
@AlvaroBrey AlvaroBrey added this to the NC Android Lib 2.15.0 milestone Feb 22, 2023
@delete-merged-branch delete-merged-branch bot deleted the properInterruptionHandling branch February 22, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants