Photo search limit #134
Merged
Photo search limit #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobiasKaminsky
force-pushed
the
photoSearchLimit
branch
from
6422003 to
8d6dc21
Compare
|
👍 |
|
Needs a rebase now that other PRs have been merged |
|
It is still under development ;-) |
|
@rullzer webdav search on server still does not have reliable pagination / limit, right? |
|
It will have it in 15 @tobiasKaminsky as @icewind1991 did work on this. |
|
@mario @icewind1991 do you have a PR link for this? So i can test it 👍 |
|
@rullzer @mario @icewind1991 anyone having a PR link for the server change to @tobiasKaminsky can test it? :) |
|
@mario @icewind1991 which PR do you mean? |
|
Might be this one? nextcloud/server#10880 |
|
Yes
…On Tue, 11 Dec 2018, 10:04 Tobias Kaminsky ***@***.*** wrote:
Might be this one? nextcloud/server#10880
<nextcloud/server#10880>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#134 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAWslp6Srp06PwMryDoRcxOd10SwiO_ks5u33UlgaJpZM4Sonp->
.
|
tobiasKaminsky
force-pushed
the
photoSearchLimit
branch
3 times, most recently
from
dfdb770 to
383b867
Compare
11 tasks
tobiasKaminsky
force-pushed
the
photoSearchLimit
branch
from
f243f14 to
a0c34f5
Compare
tobiasKaminsky
force-pushed
the
photoSearchLimit
branch
2 times, most recently
from
383b867 to
b6b2cfd
Compare
tobiasKaminsky
force-pushed
the
photoSearchLimit
branch
from
b6b2cfd to
282ca1d
Compare
AndyScherzinger
previously approved these changes
Jul 23, 2019
|
IT test failed: https://www.kaminsky.me/nc-dev/library-integrationTests/1142 |
Lint
SpotBugs (new)
SpotBugs (master)
|
|
@tobiasKaminsky test cases keep failing (probably need an update?) |
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
|
IT test failed: https://www.kaminsky.me/nc-dev/library-integrationTests/1143 |
Lint
SpotBugs (new)
SpotBugs (master)
|
|
Tests still failing and one (valid) codacy warning |
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Lint
SpotBugs (new)
SpotBugs (master)
|
Lint
SpotBugs (new)
SpotBugs (master)
|
AndyScherzinger
approved these changes
Jul 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for nextcloud/android#2250
TODO
This is still wip as the server has some problems.
While the linked PR is nice to have, this is not needed for this PR, as limit will work.
For #2250 we will just query 50 images, and for next query also 50 images but with timestamp limitation.