Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature - Add Tag Color #1622

Merged
merged 11 commits into from
Jan 21, 2025
Merged

Feature - Add Tag Color #1622

merged 11 commits into from
Jan 21, 2025

Conversation

tobiasKaminsky
Copy link
Member

@tobiasKaminsky tobiasKaminsky commented Jan 8, 2025

@alperozturk96 alperozturk96 changed the title tag color Add Tag Color Jan 8, 2025
@alperozturk96 alperozturk96 changed the title Add Tag Color Feature - Add Tag Color Jan 8, 2025
Copy link
Contributor

github-actions bot commented Jan 8, 2025

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

@alperozturk96 alperozturk96 marked this pull request as ready for review January 8, 2025 09:48
Copy link
Contributor

github-actions bot commented Jan 8, 2025

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

@alperozturk96
Copy link
Contributor

./gradlew spotlessApply not working

Copy link
Contributor

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

Copy link
Contributor

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

Copy link
Contributor

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 53.84615% with 18 lines in your changes missing coverage. Please review.

Project coverage is 22.98%. Comparing base (fe2c9ff) to head (1b59a97).

Files with missing lines Patch % Lines
...droid/lib/resources/tags/GetTagsRemoteOperation.kt 0.00% 11 Missing ⚠️
...owncloud/android/lib/common/network/WebdavEntry.kt 70.00% 5 Missing and 1 partial ⚠️
...ud/android/lib/resources/files/model/RemoteFile.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1622      +/-   ##
============================================
+ Coverage     22.89%   22.98%   +0.09%     
- Complexity      617      624       +7     
============================================
  Files           215      216       +1     
  Lines          8177     8200      +23     
  Branches       1040     1042       +2     
============================================
+ Hits           1872     1885      +13     
- Misses         6124     6135      +11     
+ Partials        181      180       -1     
Files with missing lines Coverage Δ
...ncloud/android/lib/common/network/WebdavUtils.java 88.88% <100.00%> (+0.08%) ⬆️
...d/android/lib/resources/status/NextcloudVersion.kt 92.30% <100.00%> (+0.64%) ⬆️
...cloud/android/lib/resources/systemTag/SystemTag.kt 100.00% <100.00%> (ø)
...ava/com/owncloud/android/lib/resources/tags/Tag.kt 100.00% <100.00%> (ø)
...ud/android/lib/resources/files/model/RemoteFile.kt 0.00% <0.00%> (ø)
...owncloud/android/lib/common/network/WebdavEntry.kt 82.58% <70.00%> (+0.06%) ⬆️
...droid/lib/resources/tags/GetTagsRemoteOperation.kt 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

Copy link
Contributor

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

tobiasKaminsky and others added 9 commits January 21, 2025 11:40
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@nextcloud-android-bot
Copy link
Collaborator

@nextcloud-android-bot
Copy link
Collaborator

@nextcloud-android-bot
Copy link
Collaborator

Copy link
Contributor

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

@nextcloud-android-bot
Copy link
Collaborator

@tobiasKaminsky tobiasKaminsky merged commit 40fea7d into master Jan 21, 2025
15 of 18 checks passed
@tobiasKaminsky tobiasKaminsky deleted the tagColor branch January 21, 2025 11:35
@AndyScherzinger AndyScherzinger added this to the NC Android lib 2.20.0 milestone Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants