Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse favorite attribute for OCShare on NC 25+ #968

Merged
merged 1 commit into from
Dec 19, 2022
Merged

Parse favorite attribute for OCShare on NC 25+ #968

merged 1 commit into from
Dec 19, 2022

Conversation

tobiasKaminsky
Copy link
Member

@tobiasKaminsky tobiasKaminsky commented Sep 19, 2022 •
edited by AlvaroBrey
Loading

@github-actions
Copy link
Contributor

SpotBugs (new)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 40
Total 150

SpotBugs (master)

Warning Type Number
Bad practice Warnings 17
Correctness Warnings 36
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 13
Security Warnings 1
Dodgy code Warnings 45
Total 164

SpotBugs increased!

@AlvaroBrey AlvaroBrey mentioned this pull request Sep 23, 2022
Draft
2 tasks
@nextcloud nextcloud deleted a comment from github-actions bot Sep 23, 2022
@nextcloud nextcloud deleted a comment from github-actions bot Sep 23, 2022
@nextcloud nextcloud deleted a comment from github-actions bot Sep 23, 2022
@nextcloud nextcloud deleted a comment from github-actions bot Sep 23, 2022
@github-actions
Copy link
Contributor

SpotBugs (new)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 40
Total 150

SpotBugs (master)

Warning Type Number
Bad practice Warnings 17
Correctness Warnings 36
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 13
Security Warnings 1
Dodgy code Warnings 45
Total 164

SpotBugs increased!

AlvaroBrey
AlvaroBrey requested changes Sep 23, 2022
View reviewed changes
Copy link
Member

@AlvaroBrey AlvaroBrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes requested, also please take a look at Detekt and Spotbugs

library/src/main/java/com/owncloud/android/lib/resources/shares/GetShareRemoteOperation.java Outdated Show resolved Hide resolved
library/src/main/java/com/owncloud/android/lib/resources/shares/ShareXMLParser.java Outdated Show resolved Hide resolved
library/src/main/java/com/owncloud/android/lib/resources/shares/ShareXMLParser.java Outdated Show resolved Hide resolved
@AlvaroBrey AlvaroBrey changed the title OCShare have with NC25 isFavorite Parse favorite status for OCShare on NC 25+ Sep 23, 2022
@AlvaroBrey AlvaroBrey changed the title Parse favorite status for OCShare on NC 25+ Parse favorite attribute for OCShare on NC 25+ Sep 23, 2022
@github-actions
Copy link
Contributor

SpotBugs (new)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 40
Total 150

SpotBugs (master)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 39
Total 149

SpotBugs increased!

@github-actions
Copy link
Contributor

SpotBugs (new)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 39
Total 149

SpotBugs (master)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 39
Total 149

@AlvaroBrey
Copy link
Member

/rebase

@github-actions
Copy link
Contributor

SpotBugs (new)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

SpotBugs (master)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

AlvaroBrey
AlvaroBrey previously approved these changes Nov 30, 2022
View reviewed changes
@AlvaroBrey
Copy link
Member

@tobiasKaminsky as this is kinda old I didn't wanna merge without you having a look at it, feel free to merge when you want

tobiasKaminsky added a commit to nextcloud/android that referenced this pull request Dec 5, 2022
@tobiasKaminsky
Uses: nextcloud/android-library#968
32ee154 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@tobiasKaminsky tobiasKaminsky mentioned this pull request Dec 5, 2022
Merged
1 task
@tobiasKaminsky
Copy link
Member Author

I created a branch on files for it: nextcloud/android#11138

@AlvaroBrey
Copy link
Member

/rebase

nextcloud-command pushed a commit to nextcloud/android that referenced this pull request Dec 13, 2022
@tobiasKaminsky @AlvaroBrey
Uses: nextcloud/android-library#968
e34745f 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@github-actions
Copy link
Contributor

SpotBugs (new)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

SpotBugs (master)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

AlvaroBrey
AlvaroBrey previously approved these changes Dec 13, 2022
View reviewed changes
@tobiasKaminsky
OCShare have with NC25 isFavorite
472a405 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
tobiasKaminsky added a commit to nextcloud/android that referenced this pull request Dec 13, 2022
@tobiasKaminsky
Uses: nextcloud/android-library#968
65df6ae 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@github-actions
Copy link
Contributor

SpotBugs (new)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

SpotBugs (master)

Warning Type Number
Bad practice Warnings 10
Correctness Warnings 35
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 31
Total 141

@tobiasKaminsky tobiasKaminsky merged commit 90e5e9e into master Dec 19, 2022
@delete-merged-branch delete-merged-branch bot deleted the shareAPIfavorite branch December 19, 2022 11:37
tobiasKaminsky added a commit to nextcloud/android that referenced this pull request Dec 19, 2022
@tobiasKaminsky
Uses: nextcloud/android-library#968
d57a798 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
nextcloud-command pushed a commit to nextcloud/android that referenced this pull request Dec 19, 2022
@tobiasKaminsky
Uses: nextcloud/android-library#968
e2ae54b 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
surinder-tsys added a commit to surinder-tsys/android-library that referenced this pull request Jan 20, 2023
@surinder-tsys
Parse favorite attribute for OCShare on NC 25+ as per NC PR: nextclou…
cfe7c76 
…d#968
AlvaroBrey pushed a commit to nextcloud/android that referenced this pull request Jan 25, 2023
@tobiasKaminsky @AlvaroBrey
Uses: nextcloud/android-library#968
4f1d034 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
backportbot-nextcloud bot pushed a commit to nextcloud/android that referenced this pull request Jan 25, 2023
@tobiasKaminsky @backportbot-nextcloud
Uses: nextcloud/android-library#968
e981af9 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@AndyScherzinger AndyScherzinger added this to the NC Android Lib 2.14.0 milestone Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlvaroBrey AlvaroBrey AlvaroBrey approved these changes

Assignees
No one assigned
Labels
3. to review
Projects
None yet
Milestone
NC Android Lib 2.14.0
Development

Successfully merging this pull request may close these issues.
3 participants
@tobiasKaminsky @AlvaroBrey @AndyScherzinger