Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 3.3.1 - Roadmap #3092

Closed
16 tasks done
AndyScherzinger opened this issue Sep 26, 2018 · 18 comments
Closed
16 tasks done

Release 3.3.1 - Roadmap #3092

AndyScherzinger opened this issue Sep 26, 2018 · 18 comments

Comments

@AndyScherzinger
Copy link
Member

AndyScherzinger commented Sep 26, 2018

Test app with all supported Android version

  • access all activities
  • auto upload
  • upload / download files/folders
  • use external sdcard
  • what's new slides correctly shown on first start

All tests on

  • Android 4
  • Android 5
  • Android 6
  • Android 7
  • Android 8

Final Release

  • Bump version name and version code in build.gradle files 3.3.1 RC1 #3156
  • update Changelog.md 3.3.1 RC1 #3156
    • also update Changelog.md on master branch
  • update translations from transifex
  • Verify that the new version number is shown in settings
  • Verify that logging is disabled
  • Test that what's new is shown correctly on upgrade
  • Tag new version as stable-3.3.1
  • Build and release to Play Store as stable release and :shipit:
  • Update Play store changelog based on condensed CHANGELOG.md infos
  • Verify that it is shown on f-droid (within 24h)

Backports:


PRs to be merged prior to releasing:
TODO

@nextcloud-android-bot

This comment has been minimized.

@AndyScherzinger
Copy link
Member Author

@tobiasKaminsky can we get this release please? :) It only fixes two issues, I know...but....the share type issue is the number 1 crash for the 3.3.0 release, so I think it would be nice to get this released since we already got this reported again even after the fix has been done but unfortunately not release yet :/

@tobiasKaminsky
Copy link
Member

tobiasKaminsky commented Oct 17, 2018

There is also a bug when Client is created on main thread, when entering Notification.
I'll have a look into this now and try to find a fix.
Then we can include this also.

Ref: https://gist.github.com/nickvergessen/34a6b9fb1cc2b5656eb0fc13aeee46c2

@tobiasKaminsky
Copy link
Member

#3153

@AndyScherzinger
Copy link
Member Author

approved the PR 👍

@tobiasKaminsky
Copy link
Member

Backport is in #3154, after that I'll create a RC1 as I am not 100% if the fix is correct, as I cannot reproduce the error.

@AndyScherzinger
Copy link
Member Author

Merged, since codacy is is also not a fan of non-master-targeting PRs... :/

@AndyScherzinger
Copy link
Member Author

RC1 PR is #3156, todos have been updated

@tobiasKaminsky
Copy link
Member

RC1 is released

@tobiasKaminsky
Copy link
Member

RC2 needs this: #3114
Fix in #3154 seems to be ok.

@AndyScherzinger
Copy link
Member Author

#3154 has already been merged so RC2 could be released

@AndyScherzinger
Copy link
Member Author

#3169 - 3.3.1 RC2

@tobiasKaminsky
Copy link
Member

We should also include some kind of redo of the device credentials stuff.
Seems to be broken for quite a lot people.
(I will investigate further tomorrow)

@AndyScherzinger
Copy link
Member Author

Sweet, sure thing. CI still isn't able to fetch all dependencies I guess some repo has issues, so we have to wait anyways :/

@AndyScherzinger
Copy link
Member Author

CI is working again and as far as I can see, all fixes have been merged except for a potential, still to be implemented fix for device credentials.

@tobiasKaminsky
Copy link
Member

I'll want to do RC2 today and on Monday/Tuesday 3.3.1 final, if no big issues occur.
Fingerprint is a tough one and I do not want to delay 3.3.1.
When fingerprint is working, we can do a quick 3.3.2.

@tobiasKaminsky
Copy link
Member

3.3.1 RC2 is released, stable is planned for Monday/Tuesday.

@tobiasKaminsky
Copy link
Member

Released: https://github.com/nextcloud/android/releases/tag/stable-3.3.1
Fdroid: https://gitlab.com/fdroid/fdroiddata/merge_requests/3877

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants