Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification button handling #3114

Merged
merged 1 commit into from
Oct 22, 2018
Merged

Conversation

tobiasKaminsky
Copy link
Member

  • create a task for each button
  • disable buttons until request is complete: error -> re-enable / success: delete notification
  • success check: added 202 (accepted)

Signed-off-by: tobiasKaminsky tobias@kaminsky.me

disable buttons until request is complete: error -> re-enable / success: delete notification
success check: added 202 (accepted)

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@nextcloud-android-bot
Copy link
Collaborator

Lint

TypeMasterPR
Warnings113113
Errors

FindBugs (new)

Warning TypeNumber
Bad practice Warnings35
Correctness Warnings167
Internationalization Warnings14
Malicious code vulnerability Warnings10
Multithreaded correctness Warnings9
Performance Warnings124
Security Warnings203
Dodgy code Warnings139
Total701

FindBugs (master)

Warning TypeNumber
Bad practice Warnings35
Correctness Warnings167
Internationalization Warnings14
Malicious code vulnerability Warnings10
Multithreaded correctness Warnings9
Performance Warnings124
Security Warnings203
Dodgy code Warnings139
Total701

@codecov
Copy link

codecov bot commented Oct 5, 2018

Codecov Report

Merging #3114 into master will increase coverage by <.01%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##             master   #3114      +/-   ##
===========================================
+ Coverage      6.47%   6.48%   +<.01%     
  Complexity        1       1              
===========================================
  Files           307     307              
  Lines         30111   30117       +6     
  Branches       4318    4318              
===========================================
+ Hits           1951    1952       +1     
- Misses        27867   27873       +6     
+ Partials        293     292       -1
Impacted Files Coverage Δ Complexity Δ
...ud/android/ui/adapter/NotificationListAdapter.java 0% <0%> (ø) 0 <0> (ø) ⬇️
.../third_parties/daveKoeller/AlphanumComparator.java 82.14% <0%> (+1.19%) 0% <0%> (ø) ⬇️

@nextcloud nextcloud deleted a comment Oct 8, 2018
@nextcloud nextcloud deleted a comment Oct 8, 2018
@tobiasKaminsky tobiasKaminsky mentioned this pull request Oct 22, 2018
16 tasks
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.3.1 milestone Oct 22, 2018
@AndyScherzinger
Copy link
Member

AndyScherzinger commented Oct 22, 2018

👍

Approved with PullApprove

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants