Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport #3114: create a task for each button #3172

Merged
merged 1 commit into from
Oct 24, 2018

Conversation

tobiasKaminsky
Copy link
Member

disable buttons until request is complete: error -> re-enable / success: delete notification
success check: added 202 (accepted)

Signed-off-by: tobiasKaminsky tobias@kaminsky.me

@tobiasKaminsky tobiasKaminsky added this to the Nextcloud App 3.3.1 milestone Oct 23, 2018
@AndyScherzinger
Copy link
Member

AndyScherzinger commented Oct 23, 2018

👍

Approved with PullApprove

@AndyScherzinger
Copy link
Member

Updated master lint results (actually 96 not 94 atm) so waiting for the build to turn green to merge

disable buttons until request is complete: error -> re-enable / success: delete notification
success check: added 202 (accepted)

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@nextcloud-android-bot
Copy link
Collaborator

Lint

TypeMasterPR
Warnings9495
Errors

FindBugs (new)

Warning TypeNumber
Bad practice Warnings35
Correctness Warnings164
Experimental Warnings4
Internationalization Warnings13
Malicious code vulnerability Warnings9
Multithreaded correctness Warnings9
Performance Warnings157
Security Warnings163
Dodgy code Warnings135
Total689

FindBugs (master)

Warning TypeNumber
Bad practice Warnings35
Correctness Warnings164
Experimental Warnings4
Internationalization Warnings13
Malicious code vulnerability Warnings9
Multithreaded correctness Warnings9
Performance Warnings157
Security Warnings163
Dodgy code Warnings135
Total689

@AndyScherzinger AndyScherzinger merged commit c7e072c into stable-3.3.x Oct 24, 2018
@AndyScherzinger AndyScherzinger deleted the backport-3114 branch October 24, 2018 08:11
@MorrisJobke MorrisJobke mentioned this pull request Oct 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants