Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add buttons in the notification for twofactor_nextcloud_notification #3272

Closed
GLLM opened this issue Nov 16, 2018 · 3 comments
Closed

Add buttons in the notification for twofactor_nextcloud_notification #3272

GLLM opened this issue Nov 16, 2018 · 3 comments

Comments

@GLLM
Copy link

GLLM commented Nov 16, 2018

Hello !
I use NickV's twofactor_nextcloud_notification app ever since it was released :)
It is very helpful BUT ...

When I attempt to login, I expectedly get a notification telling me about it.
I then need top open this notification : it opens the Android app and then I have a choice : Accept or Reject the connection, thanks to 2 buttons.

A better solution :
I'd really like to Approve or Reject connection from within the notification, thanks to 2 buttons.
(Messaging app often have 2 buttons in notification : Reply and Mark as read)

I initially booked an issue on the app repo (nextcloud/twofactor_nextcloud_notification#48) but I was told this should be managed by the Android app.

If this F.R. should only be about buttons, please let me know, I'll amend the Issue :)

What do you think ?
Thanks
Guillaume

@nextcloud-android-bot
Copy link
Collaborator

GitMate.io thinks possibly related issues are #559 (Notifications), #1276 (Add support for notification actions), #2340 (Add channel to notification), #3114 (Notification button handling), and #785 (Proposal: Add create file button).

@AndyScherzinger
Copy link
Member

AndyScherzinger commented Nov 16, 2018

Hi @GLLM, this is something we already started to discuss, see #1276 so I'll close this as a duplicate. Nevertheless it is from my point of view something of low/mid priority due to other features people are currently working on but is definitely something that makes sense but might take a while until somebody finds the time to implement it.

@GLLM
Copy link
Author

GLLM commented Nov 19, 2018

Thanks for your reply Andy !
Will follow #1276 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants