Detect configured instant upload folder across accounts

[schiessle]

I have two accounts configured, my private Nextcloud and my company Nextcloud.

On my private account I have configured my local media folders for instant upload. But every once and a while I get a notification that new media upload folders where detected. If I click on the notification the instant upload configuration dialog for my company account opens.

It would be nice if the Android app would detect that instant upload for this folder is already configured for a different account and don't show this notification.

[nextcloud-android-bot]

GitMate.io thinks possibly related issues are #184 (Upload whole folder), #221 (Upload activity crashes in empty folder), #553 (Going forward with instant upload), #440 (Instant upload with multiple accounts set), and #442 (Instant upload crashes client).

[AndyScherzinger]

To be discussed I guess. Tobias fixed the general detection/hidding part via #3173 (per account basis) while one could argue that a user might want to configure it per account, don't know.

Asking @nextcloud/designers @tobiasKaminsky for feedback. I'd say show it just once. If any account has this configured then don't notify the user about the "new" folder since that one is already known to the user of the device. Thus we just need to get rid of the account part in our query.

[tobiasKaminsky]

So let me summarize what we are doing on each folder detection job:

• get a list of folder for image / video from Android's media store
• remove all folders we have already processed
• loop over every account
  • see if the folder is already available (enabled/disabled) for this account
  • if yes, do nothing
  • else show a (one-time) notification

While thinking about it, this should be fine and the issue described by Björn is the bug I fixed in #3173.
@schiessle can you install dev version and try it again? In #3173 there is a test scenario.

If any account has this configured then don't notify the user about the "new" folder since that one is already known to the user of the device. Thus we just need to get rid of the account part in our query.

This is what we are doing, except that all accounts throw a notification if a (complete) new folder appears:

• new installation without any camera folder / images in gallery
• set up app with two accounts (do nothing in AutoUpload)
• take one image
• see two notification, one per each account
• delete image and folder
• take again an image
  -> see no notification as you already have them in AutoUpload settings (though disabled by default)

(this is the situation after bug fix #3173)

I am unsure how we should handle the above situation with only sending one notification, because which account shall we choose?
So I would be fine with leaving it this way.