Fix AutoUpload notification

[tobiasKaminsky]

fix #3163

• fix not working detection of already defined synced folders
• delete not used (and wrong) function

Problem was that passing everything into selection did not worked.
Also this is error prone to sql injection (yes, very theoratical with folder names), but changing it to use correct parameter solves both.

Steps to test:

• have images in camera folder
• make sure that download folder is not in media scanner (delete images from download in gallery app)
• clean installation of app
• set up camera folder
• take image -> no notification
• delete all files in camera folder
• take image -> no notification
• download image e.g. with Firefox --> see notification

Signed-off-by: tobiasKaminsky tobias@kaminsky.me

[AndyScherzinger]

👍

[AndyScherzinger]

Problem was that passing everything into selection did not worked.

Can you give me some hints here since looking at the code it kind of looks the same to me as before except for the query change using parameters. I am pretty sure I am just overlooking something looking at the diff...

[tobiasKaminsky]

I trimmed it a bit for better readability.

Old:
selection: SYNCED_FOLDER_LOCAL_PATH == localPath AND SYNCED_FOLDER_ACCOUNT == account.name
arguments: /

New:
selection: SYNCED_FOLDER_LOCAL_PATH =? AND SYNCED_FOLDER_ACCOUNT =?
arguments: new String[]{localPath, account.name}

With new system we let Android construct the query by inserting the arguments to the correct position. This prevents from SQL injection and also does correct escaping.

[AndyScherzinger]

Thanks, now I can see it. 🙏

[nextcloud-android-bot]

Lint

Type	Master	PR
Warnings	96	96
Errors

FindBugs (new)

Warning Type	Number
Bad practice Warnings	35
Correctness Warnings	167
Internationalization Warnings	14
Malicious code vulnerability Warnings	10
Multithreaded correctness Warnings	9
Performance Warnings	123
Security Warnings	203
Dodgy code Warnings	138
Total	699

FindBugs (master)

Warning Type	Number
Bad practice Warnings	35
Correctness Warnings	167
Internationalization Warnings	14
Malicious code vulnerability Warnings	10
Multithreaded correctness Warnings	9
Performance Warnings	123
Security Warnings	203
Dodgy code Warnings	139
Total	700

[codecov]

Codecov Report

Merging #3173 into master will increase coverage by <.01%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##             master   #3173      +/-   ##
===========================================
+ Coverage      6.36%   6.37%   +<.01%     
  Complexity        1       1              
===========================================
  Files           307     307              
  Lines         30118   30108      -10     
  Branches       4320    4317       -3     
===========================================
+ Hits           1918    1920       +2     
+ Misses        27913   27902      -11     
+ Partials        287     286       -1

Impacted Files	Coverage Δ	Complexity Δ
...ncloud/android/datamodel/SyncedFolderProvider.java	9.73% <0%> (+0.86%)	0 <0> (ø)	⬇️
...wncloud/android/jobs/MediaFoldersDetectionJob.java	8.33% <0%> (-0.12%)	0 <0> (ø)
.../third_parties/daveKoeller/AlphanumComparator.java	82.14% <0%> (-1.2%)	0% <0%> (ø)
...in/java/com/owncloud/android/datamodel/OCFile.java	63.42% <0%> (+1.16%)	0% <0%> (ø)	⬇️