Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BugFix - Check Account Type Before Sync Operation Execution and Instead Crashing The App Inform User #13440

Merged
merged 5 commits into from
Aug 23, 2024
Merged

BugFix - Check Account Type Before Sync Operation Execution and Instead Crashing The App Inform User #13440

merged 5 commits into from
Aug 23, 2024

Conversation

alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Aug 22, 2024 •
edited
Loading

  • Tests written, or not not needed

@alperozturk96 alperozturk96 linked an issue Aug 22, 2024 that may be closed by this pull request
java.lang.IllegalArgumentException: Trying to execute a sync operation with a storage manager for an anonymous account #13323
Closed
@alperozturk96 alperozturk96 mentioned this pull request Aug 22, 2024
Closed
@tobiasKaminsky
Copy link
Member

Do we really want to show this?
Anonymous network call should not happen, thus we can silently cancel it?
Maybe only with internal logging?

@alperozturk96
Check account type before sync operation execution and instead crash …
27b8787 
…app warn user

Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96 alperozturk96 force-pushed the bugfix/check-user-type-for-sync-operation branch from 1f24692 to 27b8787 Compare August 23, 2024 07:13
@alperozturk96
Dont show toast
9c2f7e4 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
revert changes for sync operations
1bbbb95 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
Dont start account creation if user is anonymous in fetchExternalLink…
96058c7 
…s function

Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
Remove code format
afb6396 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@github-actions GitHub Actions
Copy link

Codacy

Lint

TypemasterPR
Warnings6262
Errors33

SpotBugs

CategoryBaseNew
Bad practice6363
Correctness6464
Dodgy code305305
Experimental11
Internationalization77
Multithreaded correctness66
Performance5252
Security1818
Total516516

@github-actions GitHub Actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/13440.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@alperozturk96 alperozturk96 merged commit 5002593 into master Aug 23, 2024
22 checks passed
@alperozturk96
Copy link
Collaborator Author

/backport to stable-3.29

@backportbot backportbot bot mentioned this pull request Aug 23, 2024
Merged
2 tasks
@alperozturk96 alperozturk96 added this to the Nextcloud App 3.30.0 milestone Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasKaminsky tobiasKaminsky tobiasKaminsky approved these changes

Assignees
No one assigned
Labels
3. to review
Projects
None yet
Milestone
Nextcloud App 3.30.0
2 participants
@alperozturk96 @tobiasKaminsky