Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature - Offline File Creation #13501

Merged
merged 51 commits into from
Oct 9, 2024
Merged

Feature - Offline File Creation #13501

merged 51 commits into from
Oct 9, 2024

Conversation

alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Sep 2, 2024 •
edited
Loading

  • Tests written, or not not needed

Demo

offline_file_and_folder.mp4

@alperozturk96 alperozturk96 marked this pull request as draft September 2, 2024 08:52
@alperozturk96 alperozturk96 force-pushed the feature/offline-file-creation branch 5 times, most recently from 9310fb4 to b81733f Compare September 6, 2024 09:30
@alperozturk96 alperozturk96 marked this pull request as ready for review September 6, 2024 14:58
@alperozturk96 alperozturk96 marked this pull request as draft September 10, 2024 08:51
@alperozturk96 alperozturk96 force-pushed the feature/offline-file-creation branch 2 times, most recently from d2e0925 to 6078f37 Compare September 10, 2024 09:22
@alperozturk96 alperozturk96 marked this pull request as ready for review September 10, 2024 09:23
@nextcloud nextcloud deleted a comment from github-actions bot Sep 11, 2024
@tobiasKaminsky
Copy link
Member

This fails for me with a SQLite upgrade error.
Can you rebase it and test

  • uninstall all
  • install and run master
  • install and run this PR?

@alperozturk96 alperozturk96 force-pushed the feature/offline-file-creation branch 3 times, most recently from 2667bee to f08e256 Compare September 24, 2024 08:02
@alperozturk96
Fix license for new icon
be56a27 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
Fix license header
55a48c1 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
Add doc for addOfflineOperations
9a32ddb 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
Add doc for buildOCFilesFromShares
60aa0a0 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
Rebase master
c4f9579 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
fix codacy
72f86fc 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
Rename .java to .kt
4b5a901 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
fix ss test -- require activity crash
1c41a1f 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
Rebase, Add Migration84to85
9984571 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
Better translations
6d06f9e 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
Fix testConfirmationDialogWithThreeActionRTL ss-test
0a25085 
java.lang.IllegalStateException: Fragment OCFileListFragment{e3507e5} (fc14c972-6cfd-4593-af3a-5a1b0bcbc8a8) not attached to an activity.

Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
Fix creation and modification date
5265782 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
Add thumbnail for offline operation
b5c935c 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
Refresh list if internet connection is back
be309d5 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
Fixes
775b1f6 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
renaming handler variable
f00a896 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
fix code analytics
70b689a 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
Add Migration 85 to 86
3f8644e 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
remove unnecessary migration
be14914 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
remove unnecessary 86 db version
0f9b27e 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
revert 84 changes
3463124 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@alperozturk96
no need migration, just drop not used column
c5c7e9f 
Signed-off-by: alperozturk <alper_ozturk@proton.me>
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 8, 2024

Codacy

Lint

TypemasterPR
Warnings5959
Errors33

SpotBugs

CategoryBaseNew
Bad practice6565
Correctness6263
Dodgy code296295
Experimental11
Internationalization77
Malicious code vulnerability11
Multithreaded correctness66
Performance5353
Security1818
Total509509

This was referenced Oct 9, 2024
Closed
Closed
@tobiasKaminsky tobiasKaminsky merged commit c530e22 into master Oct 9, 2024
19 of 21 checks passed
@tobiasKaminsky tobiasKaminsky deleted the feature/offline-file-creation branch October 9, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasKaminsky tobiasKaminsky tobiasKaminsky approved these changes

@ZetaTom ZetaTom Awaiting requested review from ZetaTom

@AndyScherzinger AndyScherzinger Awaiting requested review from AndyScherzinger

Assignees
No one assigned
Labels
3. to review
Projects
🤖 🍏 Clients team
Status: ☑️ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alperozturk96 @tobiasKaminsky @AndyScherzinger