BugFix - Icon Visibilities #14030
Open
BugFix - Icon Visibilities #14030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
Screenshot Tests look good to me. Just replace the existing ones with the new ones. They are visually similar but fail due to the update of the common lib which has m3 theming so the blue and Grey tones are slightly different now 👍 |
AndyScherzinger
approved these changes
Nov 15, 2024
|
LGTM @alperozturk96 As a follow up maybe, did you see that the folder icons with an overlay are slightly smaller see their width than folders without an overlay? 🔍 |
|
@AndyScherzinger Thank you. Good point. I will update the PR. |
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
alperozturk96
force-pushed
the
bugfix/icon-visibilities
branch
from
9eba870
to
4371305
Compare
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
• Hide the people icon after sharing with at least one user (resolves share icon visibility issues).
• Use correct overlay icons for folders (e.g., shared with users, shared via link, locked, encrypted).
• Add offline operation folder type to screenshot tests.
• Fix and update broken screenshot tests.
Folders With Overlay Icon