two way sync: save updated etag #14044
Merged
+22
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
tobiasKaminsky
commented
Nov 18, 2024
•
tobiasKaminsky
commented
- Tests written, or not not needed
|
/backport to stable-3.30 |
alperozturk96
force-pushed
the
saveDownloadedFile
branch
from
045b42d
to
149ac32
Compare
|
@tobiasKaminsky Somehow Potential memory bloat in static field this is increased, and I guess it's not related with your PR. Maybe we should update the SpotBugs count? |
app/src/main/java/com/owncloud/android/operations/SynchronizeFolderOperation.java
Outdated
Show resolved
Hide resolved
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
tobiasKaminsky
force-pushed
the
saveDownloadedFile
branch
from
e61f068
to
c01fc2d
Compare
ZetaTom
approved these changes
Nov 18, 2024
|
blue-Light-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/14044-Screenshot-blue-Light-16-57 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.