Grey-out auto upload options until enabled

[mario]

Signed-off-by: Mario Danic mario@lovelyhq.com

Fixes #1260

[AndyScherzinger]

👍 looking good code wise

[mario]

@tobiasKaminsky :P

[tobiasKaminsky]

Isn't there a giant discussion how to change this at #2034 ?
Will this fit into your idea @AndyScherzinger?

[AndyScherzinger]

@tobiasKaminsky this still fits with my idea on the overall change since this is related to the on/off status while my other ideas are related to media/custom type folder pairs. Thus this is still valid 👍

[tobiasKaminsky]

The visual difference between enabled and disabled is too low in my opinion.
It is also confusing that there is an checked, but disabled checkbox (only upload on wifi).
Moreover you can click on save when the switch is disabled (left image), which is also confusing. What is saved?

I still like the idea, but somehow it is now even more confusing for me.

As we have sane defaults for these synced folders, we could enable the folder upon on save and then omit this switch in preferences dialog.

@jancborchardt

[tobiasKaminsky]

Please feedback by @nextcloud/designers, for me the questions in my last post are still open.

[mario]

@nextcloud/designers whenever you get a chance :P

[juliusknorr]

Why not just hide the additional preferences, when the auto upload is disabled and show it when the user enables it. That way it will be clear to the user, that there is nothing to do when it is disabled and the UI would be much less cluttered then.

[jancborchardt]

Absolutely agree with Julius. Unless the first setting is enabled, everything below is irrelevant and does not need to be shown.

[mario]

Can we get this merged for 3.1, and then we'll improve for 3.2? @AndyScherzinger @tobiasKaminsky

[AndyScherzinger]

I already approved and would also be fine with merging and improving upon this foundation with 3.2 cc @tobiasKaminsky

[AndyScherzinger]

@tobiasKaminsky what do you think? Imho this PR could be merged being a better solution than the actual state and improve upon it afterwards?

[tobiasKaminsky]

As we do not have to rush and next 3.2 release will be in ~6 weeks, we can make it directly better/right, or?

[mario]

Since this was done on Feb 13, I fail to see why this was not merged...

[jancborchardt]

Let’s do it :) Good first step, better than current state

[AndyScherzinger]

@tobiasKaminsky ping for review & merge ;-)

[tobiasKaminsky]

👍
I will open up a following issue to enhance this.

[AndyScherzinger]

@tobiasKaminsky the corresponding issue is assigned to milestone 3.1 -> so should this PR then be backported?

[AndyScherzinger]

Nevermind, you already wrote that in the roadmap issue for 3.1... sorry...