Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable-3.8] Remote wipe #4457

Merged
merged 1 commit into from
Sep 5, 2019
Merged

Conversation

backportbot-nextcloud[bot]
Copy link

backport of #4455

@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud App 3.8.0 milestone Sep 4, 2019
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Sep 4, 2019
@AndyScherzinger
Copy link
Member

fine with me, while I strongly vote to get rid of the Literals in Conditional Statements (codacy) since such constructs are harder to read imho.

@tobiasKaminsky
Copy link
Member

fine with me, while I strongly vote to get rid of the Literals in Conditional Statements (codacy) since such constructs are harder to read imho.

I'll fix this in master.

@tobiasKaminsky tobiasKaminsky force-pushed the backport/4455/stable-3.8 branch from 722bb98 to 07e4940 Compare September 4, 2019 13:28
@AndyScherzinger
Copy link
Member

I'll fix this in master.

👍

@tobiasKaminsky
Copy link
Member

Also fixed it here… ;-)

@tobiasKaminsky tobiasKaminsky force-pushed the backport/4455/stable-3.8 branch from 07e4940 to 83b139d Compare September 4, 2019 20:25
@nextcloud nextcloud deleted a comment Sep 4, 2019
@nextcloud nextcloud deleted a comment Sep 4, 2019
@nextcloud nextcloud deleted a comment Sep 4, 2019
@nextcloud nextcloud deleted a comment Sep 4, 2019
@nextcloud-android-bot
Copy link
Collaborator

Lint

Typestable-3.8PR
Warnings5858
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings24
Correctness Warnings69
Internationalization Warnings12
Malicious code vulnerability Warnings4
Multithreaded correctness Warnings9
Performance Warnings112
Security Warnings46
Dodgy code Warnings137
Total413

SpotBugs (stable-3.8)

Warning TypeNumber
Bad practice Warnings24
Correctness Warnings69
Internationalization Warnings12
Malicious code vulnerability Warnings4
Multithreaded correctness Warnings9
Performance Warnings110
Security Warnings46
Dodgy code Warnings137
Total411

SpotBugs increased!

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@tobiasKaminsky tobiasKaminsky force-pushed the backport/4455/stable-3.8 branch from 83b139d to b1e2f94 Compare September 5, 2019 05:27
@codecov
Copy link

codecov bot commented Sep 5, 2019

Codecov Report

Merging #4457 into stable-3.8 will increase coverage by <.01%.
The diff coverage is 6%.

@@               Coverage Diff                @@
##             stable-3.8    #4457      +/-   ##
================================================
+ Coverage         16.99%   16.99%   +<.01%     
  Complexity            1        1              
================================================
  Files               359      360       +1     
  Lines             31932    31971      +39     
  Branches           4501     4508       +7     
================================================
+ Hits               5426     5433       +7     
- Misses            25600    25636      +36     
+ Partials            906      902       -4
Impacted Files Coverage Δ Complexity Δ
...oud/android/ui/asynctasks/CheckRemoteWipeTask.java 0% <0%> (ø) 0 <0> (?)
...com/owncloud/android/ui/activity/FileActivity.java 26.41% <0%> (-0.41%) 0 <0> (ø)
...m/owncloud/android/ui/activity/DrawerActivity.java 44.46% <0%> (-0.07%) 0 <0> (ø)
...owncloud/android/ui/activity/UserInfoActivity.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...loud/android/datamodel/FileDataStorageManager.java 36.4% <0%> (ø) 0 <0> (ø) ⬇️
...a/com/owncloud/android/jobs/AccountRemovalJob.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...wncloud/android/providers/FileContentProvider.java 22.03% <54.54%> (-0.19%) 0 <0> (ø)
.../java/com/owncloud/android/utils/DisplayUtils.java 23.62% <0%> (-1.27%) 0% <0%> (ø)
.../third_parties/daveKoeller/AlphanumComparator.java 82.14% <0%> (ø) 0% <0%> (ø) ⬇️
... and 4 more

@codecov
Copy link

codecov bot commented Sep 5, 2019

Codecov Report

Merging #4457 into stable-3.8 will decrease coverage by 0.01%.
The diff coverage is 6%.

@@               Coverage Diff                @@
##             stable-3.8    #4457      +/-   ##
================================================
- Coverage         16.99%   16.98%   -0.02%     
  Complexity            1        1              
================================================
  Files               359      360       +1     
  Lines             31932    31971      +39     
  Branches           4501     4508       +7     
================================================
+ Hits               5426     5429       +3     
- Misses            25600    25639      +39     
+ Partials            906      903       -3
Impacted Files Coverage Δ Complexity Δ
...oud/android/ui/asynctasks/CheckRemoteWipeTask.java 0% <0%> (ø) 0 <0> (?)
...com/owncloud/android/ui/activity/FileActivity.java 26.41% <0%> (-0.41%) 0 <0> (ø)
...m/owncloud/android/ui/activity/DrawerActivity.java 44.46% <0%> (-0.07%) 0 <0> (ø)
...owncloud/android/ui/activity/UserInfoActivity.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...loud/android/datamodel/FileDataStorageManager.java 36.4% <0%> (ø) 0 <0> (ø) ⬇️
...a/com/owncloud/android/jobs/AccountRemovalJob.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...wncloud/android/providers/FileContentProvider.java 22.03% <54.54%> (-0.19%) 0 <0> (ø)
.../java/com/owncloud/android/utils/DisplayUtils.java 23.62% <0%> (-1.27%) 0% <0%> (ø)
...loud/android/datamodel/ThumbnailsCacheManager.java 35.03% <0%> (-0.55%) 0% <0%> (ø)
.../third_parties/daveKoeller/AlphanumComparator.java 82.14% <0%> (ø) 0% <0%> (ø) ⬇️
... and 5 more

@nextcloud-android-bot
Copy link
Collaborator

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/10842.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@nextcloud-android-bot
Copy link
Collaborator

Lint

Typestable-3.8PR
Warnings5858
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings24
Correctness Warnings69
Internationalization Warnings12
Malicious code vulnerability Warnings4
Multithreaded correctness Warnings9
Performance Warnings110
Security Warnings46
Dodgy code Warnings137
Total411

SpotBugs (stable-3.8)

Warning TypeNumber
Bad practice Warnings24
Correctness Warnings69
Internationalization Warnings12
Malicious code vulnerability Warnings4
Multithreaded correctness Warnings9
Performance Warnings110
Security Warnings46
Dodgy code Warnings137
Total411

@tobiasKaminsky tobiasKaminsky merged commit 7280553 into stable-3.8 Sep 5, 2019
@tobiasKaminsky tobiasKaminsky deleted the backport/4455/stable-3.8 branch September 5, 2019 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants