Add further media types to auto upload

[AndyScherzinger]

as discussed in #285 and numerous other issues, this PR adds further media types to the auto upload screen, starting with videos. For now video and images are split and shown twice for folders contain both e.g. the camera folder. We could also merge them into one (if we want that which is subject to discussion).

Audio is also on the agenda but I would leave it out for now until it is clear how to implement this. The reason for that is that we are querying the media store and then display all folders that contain images (and are visible to the media store, as-in indexed). So for music in case each album has it's won folder we would display all those folders which might be a lot while it does makes sense do handle it this way for video and images...

here is a screenshot of the work in progress and btw thumbnail generation and caching has been extended for video. If a format can't be read or the file is somehow corrupt we just show the standard icon:

OPEN ISSUES

• add delete capability for custom folders (delete button on the bottom left in the folder preference dialog)
• hide delete for non custom folders
• hide delete for unpersisted custom folders
• block save button in preference screen as long as not all necessary data has been set (grey out "save" text until set)
• fix filter for local folder picker (upload activity re-use) to only show folders but no files
• make Jobs aware of the folder type and only upload all file types for custom folders, video-only for video folders and image-only for image folders
• make sure a job gets removed/terminated when a custom folder setup gets deactivated or deleted
• rewrite auto upload
• adapt to customer-hack-flag which hides the per-folder setting, which is needed for custom folders and also the flag needs to be ignored for custom folders since the user (IMHO) will like to have full control over this type of auto upload folder!
• add check to prevent several custom folder definitions which define syncs on different levels of one file tree since this will either lead to duplicate uploads or even errors (in case delete after upload)
• check why successful uploads disappear from uploads view after visiting that screen a few times
• lock files while uploading
• show only current user uploads
• automatically retry manual uploads
• remove uploads screen menu
• show "Setup custom folder" even if no media folders are detected
• Make it "Set up a custom folder" where it says "Setup a custom folder" on the work in progress screen

[mario]

Hi @AndyScherzinger. First of all nice work.

a) Any specific questions?
b) No need to really I think
c) Sure as we might want to operate on that later on - integer please (0, 1, 2, etc)

[AndyScherzinger]

Thanks for the feedback @mario than I know how to proceed.

1. Will keep video and images separately
2. Will extend the db model to save the folder type

After that maybe one of you two can then work with the folder type for images and video so no videos get uploaded for an image folder and vice versa.
After that I'll then add custom folders but probably in a new PR.

Fine with you @mario @tobiasKaminsky?

[mario]

@AndyScherzinger I'm unsure if that's desirable - I would just upload whatever ends up being in the folder. But you tell me what you prefer cc @tobiasKaminsky

Update: ignore me, is too late xD

[AndyScherzinger]

I am also fine either way it is just that people asked for the separation of images and video. If we don't want to do this then I need to merge folders like camera, since it shows up twice since it is found in both media stores

[mario]

Yea, I was silly - just ignore me as I said :D Is late and I have a headache.

[AndyScherzinger]

So not an issue we just need to decide it. If we split it than it'll work like before since probably only camera folders put both into one directory..

[mario]

Like in your screenshot seems fine.

[tobiasKaminsky]

The only drawback I currently see is, that an user (like m) who wants to have video and images uploaded in the same directory, both on wifi only, have to set it up twice...
So I still would go for an approach like I mentioned here #486 (comment) but this is also net perfect, especially for the space constraints @AndyScherzinger mentioned.

I fear that this will only satisfy few users and the rest is still "complaining". So we should (at least plan) a broader approach as now audio and non-media-files are missing, and we do not have a file sized rule.

[mario]

I would maybe ignore audio anyway, and just go for "Photos", "Videos" and "Others" type, where custom folders would only have "Others", and upload everything.

[AndyScherzinger]

@tobiasKaminsky This is the PR we were talking about which might (at some point) implement the custom folders depending on my time (or anyone else`s)

[mario]

@AndyScherzinger so ... list of tasks? :D

All requested changes done

[AndyScherzinger]

👍 code fine by me, latest CR fixes done myself and also tested the update routine for the DB

• 188 comment
• 206 commit
• 314 files changed

@tobiasKaminsky awaiting your final approval :)

[AndyScherzinger]

👍 code fine by me, latest CR fixes done myself and also tested the update routine for the DB

• 191 comment
• 203 commit
• 309 files changed

@mario awaiting your final approval :)

[mario]

👍

[AndyScherzinger]

@mario @tobiasKaminsky please wait until drone completes before hitting merge! Having this PR with all checks turned green would be awesome!!!

[AndyScherzinger]

@mario @tobiasKaminsky nevermind :/ Tobias' lint fixes will trigger a bot push and thus another change rendering all approval obsolete... So whenever drone is done with the 2 rounds, let's merge... ;)

[mario]

@AndyScherzinger so you will merge that other PR in here?

[AndyScherzinger]

No, I'll merge now!

Cc @tobiasKaminsky

[tobiasKaminsky]

Hurray 🎉 🎉 🎉 🎉 🎉 🎉

[oparoz]

Many thanks guys!