Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move remote.php/webdav to remote.php/dav #8704

Merged
merged 2 commits into from
Oct 1, 2024
Merged

Move remote.php/webdav to remote.php/dav #8704

merged 2 commits into from
Oct 1, 2024

Conversation

tobiasKaminsky
Copy link
Member

@tobiasKaminsky tobiasKaminsky commented Jul 15, 2021

Signed-off-by: tobiasKaminsky tobias@kaminsky.me

Testing

Writing tests is very important. Please try to write some tests for your PR.
If you need help, please do not hesitate to ask in this PR for help.

unit tests
instrumented tests
UI tests

  • Tests written, or not not needed

@tobiasKaminsky
Copy link
Member Author

/rebase

@codecov
Copy link

codecov bot commented Jul 22, 2021

Codecov Report

Merging #8704 (a036adc) into master (d5e3f44) will increase coverage by 28.33%.
The diff coverage is 42.85%.

Additional details and impacted files
@@              Coverage Diff              @@
##             master    #8704       +/-   ##
=============================================
+ Coverage      3.21%   31.54%   +28.33%     
- Complexity      439     3425     +2986     
=============================================
  Files           575      575               
  Lines         42018    42010        -8     
  Branches       5660     5657        -3     
=============================================
+ Hits           1352    13254    +11902     
+ Misses        40579    26802    -13777     
- Partials         87     1954     +1867     
Impacted Files Coverage Δ
.../android/authentication/AuthenticatorUrlUtils.java 33.33% <33.33%> (+19.04%) ⬆️
...oud/android/operations/GetServerInfoOperation.java 73.52% <100.00%> (+73.52%) ⬆️
.../third_parties/daveKoeller/AlphanumComparator.java 85.71% <0.00%> (-2.39%) ⬇️
.../java/com/owncloud/android/datamodel/GalleryRow.kt 50.00% <0.00%> (ø)
...roid/ui/activity/ReceiveExternalFilesActivity.java 0.36% <0.00%> (+0.36%) ⬆️
...cloud/android/ui/preview/PreviewImageActivity.java 0.55% <0.00%> (+0.55%) ⬆️
...owncloud/android/ui/activity/UserInfoActivity.java 0.58% <0.00%> (+0.58%) ⬆️
...oud/android/ui/activity/NotificationsActivity.java 0.59% <0.00%> (+0.59%) ⬆️
...tcloud/client/database/migrations/RoomMigration.kt 0.75% <0.00%> (+0.75%) ⬆️
...ui/fragment/contactsbackup/BackupListFragment.java 0.94% <0.00%> (+0.94%) ⬆️
... and 287 more

@tobiasKaminsky
Copy link
Member Author

/rebase

@github-actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/8704.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@nextcloud-android-bot
Copy link
Collaborator

Codacy

Lint

TypemasterPR
Warnings112112
Errors11

SpotBugs (new)

Warning Type Number
Bad practice Warnings 28
Correctness Warnings 50
Internationalization Warnings 9
Malicious code vulnerability Warnings 156
Multithreaded correctness Warnings 9
Performance Warnings 68
Security Warnings 40
Dodgy code Warnings 98
Total 458

SpotBugs (master)

Warning Type Number
Bad practice Warnings 28
Correctness Warnings 50
Internationalization Warnings 9
Malicious code vulnerability Warnings 156
Multithreaded correctness Warnings 9
Performance Warnings 68
Security Warnings 40
Dodgy code Warnings 98
Total 458

@github-actions
Copy link

github-actions bot commented Feb 8, 2023

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Copy link

github-actions bot commented Oct 1, 2024

Codacy

Lint

TypemasterPR
Warnings5959
Errors33

SpotBugs

CategoryBaseNew
Bad practice6464
Correctness6363
Dodgy code296296
Experimental11
Internationalization77
Malicious code vulnerability11
Multithreaded correctness66
Performance5353
Security1818
Total509509

@tobiasKaminsky tobiasKaminsky merged commit 69a3ef3 into master Oct 1, 2024
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants