Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to compiled handlebars #120

Merged
merged 2 commits into from
Nov 16, 2018
Merged

Move to compiled handlebars #120

merged 2 commits into from
Nov 16, 2018

Conversation

rullzer
Copy link
Member

@rullzer rullzer commented Oct 17, 2018

Signed-off-by: Roeland Jago Douma roeland@famdouma.nl

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@nickvergessen
Copy link
Member

Argl, so far the comments stuff was a simple copy from the comments app and then s/OCP.Comments/OCA.AnnouncementCenter
Is that still the case and possible?

@rullzer
Copy link
Member Author

rullzer commented Oct 18, 2018

Argl, so far the comments stuff was a simple copy from the comments app and then s/OCP.Comments/OCA.AnnouncementCenter
Is that still the case and possible?

I'm not entirely sure what that means. I just moved the templates out.

@juliusknorr
Copy link
Member

@nickvergessen I see no issue with that, as long as you run the handlebars command after "syncing" the updates with the comments apps code 😉

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen merged commit cd2daf4 into master Nov 16, 2018
@nickvergessen nickvergessen deleted the csp branch November 16, 2018 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants