Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a Dashboard widget #209

Merged
merged 16 commits into from
Sep 11, 2020
Merged

Add a Dashboard widget #209

merged 16 commits into from
Sep 11, 2020

Conversation

nickvergessen
Copy link
Member

Bright Dark
Bildschirmfoto von 2020-09-08 16-30-44 Bildschirmfoto von 2020-09-08 16-31-37

First I had an overlay icon added as I think it looks nice. But it has issues to adapt to bright/dark mode easily. I think the api needs some tweaking there:

Bright Dark
Bildschirmfoto von 2020-09-08 16-35-02 Bildschirmfoto von 2020-09-08 16-28-33

@nickvergessen
Add a Dashboard widget
805d7fd 
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
nickvergessen commented Sep 8, 2020
View reviewed changes
src/views/Dashboard.vue Outdated Show resolved Hide resolved
nickvergessen
nickvergessen commented Sep 8, 2020
View reviewed changes
src/views/Dashboard.vue Outdated Show resolved Hide resolved
@julien-nc julien-nc mentioned this pull request Sep 8, 2020
Merged
@nickvergessen
Add composer files
bc9e783 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Fix PHP cs
97dcddf 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Run stylelint
d70104c 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Remove unused code after @nextcloud/vue-dashboard 0.1.9
1632a13 
Signed-off-by: Joas Schilling <coding@schilljs.com>
juliushaertl
juliushaertl approved these changes Sep 10, 2020
View reviewed changes
Copy link
Member

@juliushaertl juliushaertl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small enhancement suggestion for the bootstrap code, but looks good to me 👍

@nickvergessen
Show 7 announcements by default so the dashboard is inline
ffc63f6 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Copy link
Member Author

And needs a lib bump to @nextcloud/vue-dashboard 1.0.0

@nickvergessen
Update libs
d8ee763 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Use dark icon
a9b9552 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
No icon and no status
e91b6f3 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Use injectFn()
4a64835 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Bump version to 4.0.0
8ed1964 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Make functions executable
8aa7b45 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Update tests
92043f5 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Fix all warnings
75ea185 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Fix CS
c2dc6f0 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
No more coverage with scrutinizer
516f1a3 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen merged commit 9ee3857 into master Sep 11, 2020
@delete-merged-branch delete-merged-branch bot deleted the feature/noid/dashboard branch September 11, 2020 14:55
@nickvergessen nickvergessen mentioned this pull request Oct 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliushaertl juliushaertl Awaiting requested review from juliushaertl

Assignees
No one assigned
Labels
3. to review enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nickvergessen @juliushaertl