Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start with Vue #218

Merged
merged 20 commits into from
Dec 15, 2020
Merged

Start with Vue #218

merged 20 commits into from
Dec 15, 2020

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Sep 29, 2020

Fix #179
Fix #217

General

New announcement composer

  • Some more space on top, e.g. 80px
  • Disable "Announce" button while subject is empty
  • Inline validation for too long announcement title
  • Remove "Add announcement" heading and instead change "Subject…" placeholder to "New announcement subject"
  • Textarea placeholder to "Write announcement text, Markdown can be used …"
  • Style the "Subject" field as h2, incl bolding
  • Reduce default height of textarea to 3 rows and use autosize to automatically size the height (remove the drag handle too)
  • "Advanced options" into 3 dot menu
  • Make sure buttons are 44px min
  • "Announce" button should go to the right
  • "Announce" button could include targets, like "Announce to everyone" or "Announce to engineering group", "Announce to marketing and 3 more groups"
  • Group selection can then also go into 3-dot-menu
  • Think about if elements should be included like Text app parts for basic formatting like bold etc, or the emoji picker

Announcement list

  • Fade/cut long announcement texts after 5 lines, just like in comments. Click toggles expand/collapse
  • Subline: Alice Ada 19 minutes ago, visible to everyone (as text, not icon), 0 comments
    • Missing support for the group list (we only have the ids at the moment, not the display names)
  • "Clear notifications" and "Delete announcement" should go to a 3-dot menu on the right
  • Remove horizontal divider line
  • position:sticky the header part of each announcement, use same white to transparent fade as in mail heading
  • "5 comments" put below the text, on the left – only clicking that should open the sidebar
    • Actually open the sidebar
  • Title subline and "5 comments" in var(--color-text-maxcontrast)
  • Markdown rendering is missing

@nickvergessen
Copy link
Member Author

Design-wise the announcements list is ready:
Bildschirmfoto von 2020-10-04 14-18-32

@nickvergessen
Copy link
Member Author

Bildschirmfoto von 2020-10-04 16-19-07

Need some help on moving the group selection in place. Also I'm not too sure about this point:

"Announce" button could include targets, like "Announce to everyone" or "Announce to engineering group", "Announce to marketing and 3 more groups"

Would make the code rather complex, but yeah then the selection could be moved to the menu I guess?

cc @jancborchardt @ma12-co

@jancborchardt
Copy link
Member

jancborchardt commented Oct 6, 2020

Nice work! :)

Now that we collapse the content of announcements, I think we don’t need the sticky header anymore. It looks a bit off to have it sticky even though it’s collapsed.

"Announce" button could include targets, like "Announce to everyone" or "Announce to engineering group", "Announce to marketing and 3 more groups"

Would make the code rather complex, but yeah then the selection could be moved to the … menu I guess?

Yep – while it would make the code more complex, it would make the interface nice and clean. :) And yes then we can move the selection into the 3-dot-menu.

Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Copy link
Member Author

Raised issues for the missing group selection and markdown support, so we can finally get this PR in.

…iselects

Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen merged commit d4c9edc into master Dec 15, 2020
@delete-merged-branch delete-merged-branch bot deleted the feature/noid/vue branch December 15, 2020 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🖌️ Design review comments make entry form fit width of screen & less high
2 participants