Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown support #277

Merged
merged 3 commits into from
Feb 1, 2021
Merged

Markdown support #277

merged 3 commits into from
Feb 1, 2021

Conversation

nickvergessen
Copy link
Member

Fix #258

Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the bugfix/258/markdown-support branch from cca0a12 to cd08660 Compare January 26, 2021 22:58
@nickvergessen
Copy link
Member Author

nickvergessen commented Jan 26, 2021

cc @splitt3r you want to test this (as you upvoted the issue)?

@nickvergessen
Copy link
Member Author

@sahalsaad @Schmuuu care to review since you helped with the previous implementation: #130

@splitt3r
Copy link

splitt3r commented Jan 28, 2021

Great work! I will try to find the time to have a look at it 👍🏻. But i can't promise anything as i'm not using the app and have to setup the dev environment first.

@@ -14,6 +14,7 @@
"stylelint:fix": "stylelint css/*.css css/*.scss src/**/*.scss src/**/*.vue --fix"
},
"dependencies": {
"@juliushaertl/vue-richtext": "^1.0.1",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason for not moving this under the Nextcloud org?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Schmuuu
Copy link

Schmuuu commented Jan 31, 2021

Hi @nickvergessen,
I'm sorry for the late reply, have to work a lot. Could you let me know, how I can install this version for testing? Do I simply have to download this branch (https://github.com/nextcloud/announcementcenter/tree/bugfix/258/markdown-support) as zip file and extract it into nextcloud/apps/announcementcenter or what are the exact steps?

@nickvergessen
Copy link
Member Author

Well you need to build the js/ folder too. I will upload a package tomorrow

@Schmuuu
Copy link

Schmuuu commented Jan 31, 2021

A few seconds before your comment I downloaded the zip and extracted it into the apps folder. I had to click the "Continue" button in the web browser for the update of this app.

The final message however was: "The following apps have been disabled: announcementcenter (incompatible)"
I noticed that it requires NC 21. Is it possible to run this app on NC 20.0.x as well? I could manually change the min version in the info.xml if you say, the app should run in NC20 as well.

@splitt3r
Copy link

splitt3r commented Jan 31, 2021

Great work!

image

  • External mages won´t work by intention right? Maybe a small hint about it? Could be very interesting vor announcements. Sth. like an marketing image from the companies website.
  • What about a rich(er) text editor? With buttons for bold etc.

Btw. Nextcloud Docker works great too 👍🏻

@nickvergessen
Copy link
Member Author

External mages won´t work by intention right? Maybe a small hint about it? Could be very interesting vor announcements. Sth. like an marketing image from the companies website.

Well same URL should work, it's the CSP issue. Maybe we add a allow-list option in the admin settings at some point. But at least it's unchanged from old v4 behaviour.

What about a rich(er) text editor? With buttons for bold etc.

It's a future topic, since it's not a regression from v4 at least. I plan to use https://nextcloud-vue-components.netlify.app/#/Components/RichContenteditable Doesn't have any buttons yet, but at least would allow mentions.

@nickvergessen
Copy link
Member Author

Thanks for testing and the feedback!

@nickvergessen nickvergessen merged commit 30fd2fd into master Feb 1, 2021
@delete-merged-branch delete-merged-branch bot deleted the bugfix/258/markdown-support branch February 1, 2021 12:32
@nickvergessen
Copy link
Member Author

Copied the feedback to #283 and #284

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Markdown support of announcements is missing
3 participants