-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Markdown support #277
Markdown support #277
Conversation
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
cca0a12
to
cd08660
Compare
cc @splitt3r you want to test this (as you upvoted the issue)? |
@sahalsaad @Schmuuu care to review since you helped with the previous implementation: #130 |
Great work! I will try to find the time to have a look at it 👍🏻. But i can't promise anything as i'm not using the app and have to setup the dev environment first. |
@@ -14,6 +14,7 @@ | |||
"stylelint:fix": "stylelint css/*.css css/*.scss src/**/*.scss src/**/*.vue --fix" | |||
}, | |||
"dependencies": { | |||
"@juliushaertl/vue-richtext": "^1.0.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason for not moving this under the Nextcloud org?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to poke here https://github.com/juliushaertl/vue-richtext/issues :D
Hi @nickvergessen, |
Well you need to build the js/ folder too. I will upload a package tomorrow |
A few seconds before your comment I downloaded the zip and extracted it into the apps folder. I had to click the "Continue" button in the web browser for the update of this app. The final message however was: "The following apps have been disabled: announcementcenter (incompatible)" |
Well same URL should work, it's the CSP issue. Maybe we add a allow-list option in the admin settings at some point. But at least it's unchanged from old v4 behaviour.
It's a future topic, since it's not a regression from v4 at least. I plan to use https://nextcloud-vue-components.netlify.app/#/Components/RichContenteditable Doesn't have any buttons yet, but at least would allow mentions. |
Thanks for testing and the feedback! |
Fix #258