Don't load comment sidebar when the active announcement doesn't allow comments #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… comments When linked to directly though /?announcement=1, the sidebar always opened and showed an error telling that loading comments is impossible. On backend this gives a sabre exception: « Entity does not exist or is not available » Signed-off-by: Thomas Citharel <tcit@tcit.fr>
|
Will have a look, but mostlikely only after the winter break |
nickvergessen
approved these changes
Jan 4, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When linked to directly though
/?announcement=1, the sidebar always opened and showed an error telling that loading comments is impossible.On backend this gives a sabre exception: « Entity does not exist or is not available », so we want to avoid to make that call.
A drawback is that we now have to wait for the full announcement list to be loaded before loading the comment sidebar.
Similar to #364