Skip to content
This repository has been archived by the owner on Oct 26, 2019. It is now read-only.

user_external bump to 15 #69

Merged
merged 1 commit into from
Dec 20, 2018
Merged

user_external bump to 15 #69

merged 1 commit into from
Dec 20, 2018

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Dec 15, 2018

@violoncelloCH
Copy link
Member

@skjnldsv sign-off missing on the commit? If I'm right the check is failing because of that.

@violoncelloCH
Copy link
Member

As I've described in nextcloud/server#12506 (comment), I manually changed the max-version in a live installation during the update process which led to an unhandled OCP\AutoloadNotAllowedException. Moving user_external away and back into apps/ and disabling/enabling multiple times solved this. I also had to change the max-version to 15 again, because it was somehow overwritten back to 14. I hope that was only a problem because I was already in the upgrade process while changing the max-version. If so these changes here should be sufficient.

@violoncelloCH
Copy link
Member

also, will this be part of 15.0.1 or do we have a possibility to put it in a new build of 15.0.0 to prevent other people from recieving the same error during updating?

@MariusBluem
Copy link
Member

also, will this be part of 15.0.1 or do we have a possibility to put it in a new build of 15.0.0 to prevent other people from recieving the same error during updating?

15.0.1 should be fine :)

@MariusBluem
Copy link
Member

We could also ship this as an Independent app update via our appstore, as we did it for hotfixes with files_pdfviewer

@violoncelloCH
Copy link
Member

I would go for the appstore update if possible, so we can do it as soon as possible :)

@violoncelloCH
Copy link
Member

violoncelloCH commented Dec 19, 2018

@MariusBluem if we extract user_external in a seperated repo as proposed here #59 (comment) by @jancborchardt and if I'll be a new co-maintainer of this app I could probably do the appstore release if you want...

@MariusBluem
Copy link
Member

@MariusBluem if we extract user_external in a seperated repo as proposed here #59 (comment) by @jancborchardt and if I'll be a new co-maintainer of this app I could probably do the appstore release if you want...

@jancborchardt @violoncelloCH Just to inform you: I have transferred all issues from /apps/ to /user_external/ ... So we will continue there to track everything. Code is still here - I think the best thing would be to move this simply by downloading and importing - don't think we will hardly miss that git history 🤔

@MariusBluem MariusBluem mentioned this pull request Dec 20, 2018
@nickvergessen
Copy link
Member

We can also copy the repo code over and removr all other apps from there...

But i would let morris do that because the release script needs adjustments

@violoncelloCH
Copy link
Member

violoncelloCH commented Dec 20, 2018

@MariusBluem : thank you for moving the issues!

We can also copy the repo code over and removr all other apps from there...

@nickvergessen & @MariusBluem : @MorrisJobke suggested to use a way to preserve the history in #59 (comment)

@MorrisJobke : Am I right that we will first move/copy the app to the new repo and then detach it from the server release and publish it to the appstore?

@skjnldsv : could we get in this PR as soon as possible so I can start moving the code to the new repo? Or is there a way to move PRs as well @MariusBluem? EDIT: I've just seen that there are a few other open PRs. What do we do with them?

@skjnldsv skjnldsv merged commit 9e10745 into master Dec 20, 2018
@skjnldsv skjnldsv deleted the user_external-15 branch December 20, 2018 13:52
@skjnldsv
Copy link
Member Author

As you wish 🌠

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade from 14 to 15.0.0 failed with activated user_external
4 participants