Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SPDX header #586

Merged
merged 5 commits into from
Apr 23, 2024
Merged

Add SPDX header #586

merged 5 commits into from
Apr 23, 2024

Conversation

AndyScherzinger
Copy link
Member

No description provided.

@AndyScherzinger
Add SPDX header
f50d670 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
Copy link
Member Author

/compile /

nextcloud-command and others added 4 commits April 23, 2024 11:53
@nextcloud-command
chore(assets): Recompile assets
e3dcf0d 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@AndyScherzinger
handle remaining, generated assets via dep5 definition
b7a47eb 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
Add REUSE check via GH action
b95964e 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
Add empty line at the eof
c670f55 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger AndyScherzinger added this to the Nextcloud 30 milestone Apr 23, 2024
@AndyScherzinger AndyScherzinger merged commit c23e1e5 into master Apr 23, 2024
32 checks passed
@AndyScherzinger AndyScherzinger deleted the chore/noid/REUSE-SPDX branch April 23, 2024 17:19
@AndyScherzinger
Copy link
Member Author

@blizzz @Altahrim @skjnldsv see change below. I would like to test-drive this in 29.0.1 to ensure this works fine with the checksum / file-list stuff on packaging well, when running a Nextcloud, to not run into issues with the updater (which we saw happening with adding the dependency lock files back in September last year).

So I would only ask merging the v29 backport upon your feedback.

@AndyScherzinger
Copy link
Member Author

Thanks a lot for the review and approval @DorraJaouad - highly appreciated 💯

@AndyScherzinger
Copy link
Member Author

/backport to stable29

@backportbot backportbot bot mentioned this pull request Apr 23, 2024
Closed
2 tasks
@blizzz
Copy link
Member

blizzz commented May 23, 2024

@blizzz @Altahrim @skjnldsv see change below. I would like to test-drive this in 29.0.1 to ensure this works fine with the checksum / file-list stuff on packaging well, when running a Nextcloud, to not run into issues with the updater (which we saw happening with adding the dependency lock files back in September last year).

So I would only ask merging the v29 backport upon your feedback.

the updater adjustment was only merged to master, also i am only aware this is a thing for 30.

@blizzz blizzz mentioned this pull request Jul 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DorraJaouad DorraJaouad DorraJaouad approved these changes

Assignees
No one assigned
Labels
3. to review technical debt
Projects
None yet
Milestone
Nextcloud 30
Development

Successfully merging this pull request may close these issues.
4 participants
@AndyScherzinger @blizzz @DorraJaouad @nextcloud-command