Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework reflow on the mobile devices #4283

Open
JuliaKirschenheuter opened this issue Jun 13, 2022 · 12 comments
Open

Rework reflow on the mobile devices #4283

JuliaKirschenheuter opened this issue Jun 13, 2022 · 12 comments
Labels
0. to triage Pending approval or rejection bug

Comments

@JuliaKirschenheuter
Copy link
Contributor

Steps to reproduce

This is an accessibility issue.

When using the app on a smaller, vertical screen and activating “New event” a fly-out menu opens from the right. This should open on top of interface, but it opens under the menu field, and the user won’t be able to reach it.

This does not technically fail this WCAG-criterion, though it would be a serious issue for someone trying to use the app on a mobile phone.

Expected behavior

Popover comes in front (on the top) of the view.

Actual behaviour

At the moment it looks like this

image

Calendar app version

3.3.2

CalDAV-clients used

No response

Browser

No response

Client operating system

No response

Server operating system

No response

Web server

No response

Database engine version

No response

PHP engine version

No response

Nextcloud version

No response

Updated from an older installed version or fresh install

No response

List of activated apps

No response

Nextcloud configuration

No response

Web server error log

No response

Log file

No response

Browser log

No response

Additional info

No response

@JuliaKirschenheuter JuliaKirschenheuter added 1. to develop Accepted and waiting to be taken care of bug labels Jun 13, 2022
@szaimen
Copy link
Contributor

szaimen commented Jun 13, 2022

Does nextcloud-libraries/nextcloud-vue#2747 address this?

@ChristophWurst ChristophWurst added 0. to triage Pending approval or rejection and removed 1. to develop Accepted and waiting to be taken care of labels Jun 14, 2022
@JuliaKirschenheuter
Copy link
Contributor Author

JuliaKirschenheuter commented Jun 14, 2022

Does nextcloud-libraries/nextcloud-vue#2747 address this?

This ticket fixes a problem with a sidebar.

I've tested it with modal + (not completely) hidden sidebar - and this doesn't work

@szaimen
Copy link
Contributor

szaimen commented Jun 14, 2022

I've tested it with modal + (not completely) hidden sidebar - and this doesn't work

Can you post a screenshot of this?

@JuliaKirschenheuter
Copy link
Contributor Author

I've tested it with modal + (not completely) hidden sidebar - and this doesn't work

Can you post a screenshot of this?

This one #4283 (comment)

@szaimen
Copy link
Contributor

szaimen commented Jun 15, 2022

This one #4283 (comment)

Okay but this should be fixed with nextcloud-libraries/nextcloud-vue#2747 due to the z-index change...

@JuliaKirschenheuter
Copy link
Contributor Author

Okay but this should be fixed with nextcloud/nextcloud-vue#2747 due to the z-index change...

Hm, i've tested it, but haven't seen a difference. Could you test it too?

@szaimen
Copy link
Contributor

szaimen commented Jun 15, 2022

If you have tested it I guess it does not work as expected... Can you show a screenshot of your test? Does it still look the same like your initial report here?

@JuliaKirschenheuter
Copy link
Contributor Author

Does it still look the same like your initial report here?

yes =(

@szaimen
Copy link
Contributor

szaimen commented Jun 15, 2022

yes =(

Then your test does not seem to work... Did you clear all caches and linked the vue repo correctly?

@szaimen
Copy link
Contributor

szaimen commented Jun 15, 2022

yes =(

Then your test does not seem to work... Did you clear all caches and linked the vue repo correctly?

I am asking because at least the right sidebar should then span the whole width on mobile (below 512px)

@szaimen
Copy link
Contributor

szaimen commented Jul 27, 2022

This can now be tested again with https://github.com/nextcloud/nextcloud-vue/releases/tag/v6.0.0-alpha.0

@szaimen
Copy link
Contributor

szaimen commented Sep 26, 2022

Also the new calendar beta release contains this fix now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. to triage Pending approval or rejection bug
Projects
None yet
Development

No branches or pull requests

3 participants