Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add integration tests to CI and composer.json command #5311

Merged
merged 1 commit into from
Jul 3, 2023

Conversation

miaulalala
Copy link
Contributor

No description provided.

@miaulalala miaulalala added the 3. to review Waiting for reviews label Jun 12, 2023
@miaulalala miaulalala self-assigned this Jun 12, 2023
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (31ef432) 22.78% compared to head (b01cdb6) 22.78%.

❗ Current head b01cdb6 differs from pull request most recent head 488d8f6. Consider uploading reports for the commit 488d8f6 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #5311   +/-   ##
=========================================
  Coverage     22.78%   22.78%           
  Complexity      371      371           
=========================================
  Files           237      237           
  Lines         11636    11636           
  Branches       2255     2255           
=========================================
  Hits           2651     2651           
  Misses         8985     8985           
Flag Coverage Δ
javascript 13.98% <ø> (ø)
php 65.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clover options moved into previous step. drop them

.github/workflows/php-test.yml Outdated Show resolved Hide resolved
@ChristophWurst
Copy link
Member

ChristophWurst commented Jun 12, 2023

if's sufficient to re-request a review. you don't have to dismiss :)

this also ensures the person requesting changes gets a chance to have another look before the merge

@miaulalala miaulalala force-pushed the chore/add-integration-tests-CI branch 2 times, most recently from 119e5b9 to f6e249c Compare July 3, 2023 12:40
@miaulalala miaulalala enabled auto-merge July 3, 2023 12:40
Signed-off-by: Anna Larch <anna@nextcloud.com>
@miaulalala miaulalala force-pushed the chore/add-integration-tests-CI branch from b01cdb6 to 488d8f6 Compare July 3, 2023 13:56
@miaulalala miaulalala merged commit 2f22e5e into main Jul 3, 2023
@miaulalala miaulalala deleted the chore/add-integration-tests-CI branch July 3, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
Development

Successfully merging this pull request may close these issues.

3 participants