Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simpler locale fall back code #5418

Merged
merged 1 commit into from
Sep 9, 2023

Conversation

jmcclelland
Copy link
Contributor

@jmcclelland jmcclelland commented Aug 17, 2023

fixes #5257

@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.04% ⚠️

Comparison is base (b6e4fae) 22.65% compared to head (bddcaa3) 22.62%.
Report is 45 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5418      +/-   ##
============================================
- Coverage     22.65%   22.62%   -0.04%     
- Complexity      387      395       +8     
============================================
  Files           240      241       +1     
  Lines         11825    11843      +18     
  Branches       2302     2305       +3     
============================================
  Hits           2679     2679              
- Misses         9146     9164      +18     
Flag Coverage Δ
javascript 13.82% <0.00%> (+<0.01%) ⬆️
php 64.26% <ø> (-0.63%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...NavigationHeader/AppNavigationHeaderDatePicker.vue 0.00% <ø> (ø)
...ppNavigationHeader/AppNavigationHeaderNewEvent.vue 0.00% <ø> (ø)
...avigationHeader/AppNavigationHeaderTodayButton.vue 0.00% <ø> (ø)
...ppNavigationHeader/AppNavigationHeaderViewMenu.vue 0.00% <ø> (ø)
...components/AppNavigation/AppointmentConfigList.vue 0.00% <0.00%> (ø)
...ppointmentConfigList/AppointmentConfigListItem.vue 0.00% <0.00%> (ø)
...ts/AppNavigation/CalendarList/CalendarListItem.vue 0.00% <0.00%> (ø)
...nts/AppNavigation/CalendarList/CalendarListNew.vue 0.00% <0.00%> (ø)
...Navigation/CalendarList/PublicCalendarListItem.vue 0.00% <0.00%> (ø)
...components/AppNavigation/CalendarList/Trashbin.vue 0.00% <0.00%> (ø)
... and 56 more

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.

@ChristophWurst ChristophWurst added the 3. to review Waiting for reviews label Aug 17, 2023
@ChristophWurst ChristophWurst changed the title simpler locale fall back code, fixes #5257 simpler locale fall back code Aug 17, 2023
@st3iny st3iny added this to the v4.6.0 milestone Sep 5, 2023
@st3iny
Copy link
Member

st3iny commented Sep 5, 2023

/backport to stable4.5

@st3iny
Copy link
Member

st3iny commented Sep 5, 2023

/backport to stable4.4

@backportbot-nextcloud backportbot-nextcloud bot added the backport-request A backport was requested for this pull request label Sep 5, 2023
Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes make sense.

@st3iny
Copy link
Member

st3iny commented Sep 5, 2023

@jmcclelland Please sign off your commit.

To add your Signed-off-by line to every commit in this branch:

  1. Ensure you have a local copy of your branch by checking out the pull request locally via command line.
  2. In your local branch, run: git rebase HEAD~1 --signoff
  3. Force push your changes to overwrite the branch: git push --force-with-lease origin argentina-arabic-locale

src/utils/moment.js Outdated Show resolved Hide resolved
Signed-off-by: Jamie McClelland <jm@mayfirst.org>
@jmcclelland
Copy link
Contributor Author

@st3iny The comment typo should be fixed and I followed the directions on sign off. Let me know if there is anything else I can should do.

@st3iny st3iny merged commit 2c769c1 into nextcloud:main Sep 9, 2023
38 of 40 checks passed
Copy link

github-actions bot commented May 1, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews backport-request A backport was requested for this pull request bug feedback-requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect language loaded for Spanish (Argentina)
4 participants