-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
simpler locale fall back code #5418
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #5418 +/- ##
============================================
- Coverage 22.65% 22.62% -0.04%
- Complexity 387 395 +8
============================================
Files 240 241 +1
Lines 11825 11843 +18
Branches 2302 2305 +3
============================================
Hits 2679 2679
- Misses 9146 9164 +18
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. 📢 Have feedback on the report? Share it here. |
/backport to stable4.5 |
/backport to stable4.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes make sense.
@jmcclelland Please sign off your commit. To add your Signed-off-by line to every commit in this branch:
|
Signed-off-by: Jamie McClelland <jm@mayfirst.org>
1aae1c9
to
bddcaa3
Compare
@st3iny The comment typo should be fixed and I followed the directions on sign off. Let me know if there is anything else I can should do. |
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
fixes #5257