Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove support for php7.4 #5607

Merged
merged 1 commit into from
Dec 6, 2023
Merged

chore: remove support for php7.4 #5607

merged 1 commit into from
Dec 6, 2023

Conversation

miaulalala
Copy link
Contributor

No description provided.

@miaulalala miaulalala added the 3. to review Waiting for reviews label Dec 5, 2023
@miaulalala miaulalala added this to the v4.7.0 milestone Dec 5, 2023
@miaulalala miaulalala self-assigned this Dec 5, 2023
Copy link

codecov bot commented Dec 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (df2d51b) 24.53% compared to head (6318d5f) 24.53%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #5607   +/-   ##
=========================================
  Coverage     24.53%   24.53%           
  Complexity      418      418           
=========================================
  Files           243      243           
  Lines         10785    10785           
  Branches       1755     1755           
=========================================
  Hits           2646     2646           
  Misses         8139     8139           
Flag Coverage Δ
javascript 15.57% <ø> (ø)
php 61.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@tcitworld tcitworld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also change config>platform>php in composer.json.

@tcitworld
Copy link
Member

And change requirement on php in composer.json as well

@st3iny
Copy link
Member

st3iny commented Dec 5, 2023

@miaulalala
Copy link
Contributor Author

Changed php requirements and platform to 8.0

Signed-off-by: Anna Larch <anna@nextcloud.com>
@miaulalala miaulalala merged commit bad52db into main Dec 6, 2023
38 checks passed
@miaulalala miaulalala deleted the chore/remove-php7.4 branch December 6, 2023 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
Development

Successfully merging this pull request may close these issues.

3 participants