Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(files): replace input fields with NcTextField #5936

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

JuliaKirschenheuter
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter commented Apr 19, 2024

Fixes #5864

Details tab for reminders:

Before After
image Screenshot from 2024-04-22 17-21-04

Resources tab:

Before After
image Screenshot from 2024-04-22 17-21-53

Copy link

codecov bot commented Apr 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 23.94%. Comparing base (110f948) to head (31dd0e9).
Report is 20 commits behind head on main.

Files Patch % Lines
...rc/components/Editor/Repeat/RepeatFreqInterval.vue 0.00% 4 Missing ⚠️
...nents/Editor/Resources/ResourceSeatingCapacity.vue 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5936      +/-   ##
============================================
+ Coverage     23.20%   23.94%   +0.73%     
  Complexity      455      455              
============================================
  Files           247      247              
  Lines         11499    11512      +13     
  Branches       1929     1933       +4     
============================================
+ Hits           2668     2756      +88     
+ Misses         8831     8756      -75     
Flag Coverage Δ
javascript 15.50% <0.00%> (+0.93%) ⬆️
php 58.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JuliaKirschenheuter JuliaKirschenheuter marked this pull request as ready for review April 22, 2024 15:24
@JuliaKirschenheuter JuliaKirschenheuter self-assigned this Apr 22, 2024
@JuliaKirschenheuter JuliaKirschenheuter added the 3. to review Waiting for reviews label Apr 22, 2024
@st3iny st3iny force-pushed the fix/5864-Align_heights_and_widths_for_inputs branch from 3b48f02 to 815b639 Compare April 23, 2024 12:45
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
@st3iny st3iny force-pushed the fix/5864-Align_heights_and_widths_for_inputs branch from 815b639 to 31dd0e9 Compare April 23, 2024 12:54
Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works.

@st3iny st3iny added design Related to design, interface, interaction design, UX, etc. 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 23, 2024
@st3iny st3iny added this to the v4.8.0 milestone Apr 23, 2024
@st3iny st3iny enabled auto-merge April 23, 2024 12:55
@st3iny st3iny merged commit dea2112 into main Apr 24, 2024
41 of 42 checks passed
@st3iny st3iny deleted the fix/5864-Align_heights_and_widths_for_inputs branch April 24, 2024 06:37
Copy link

github-actions bot commented May 4, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish design Related to design, interface, interaction design, UX, etc. feedback-requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Align heights and widths for inputs in EditorSidebar
2 participants