-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make certain wordings translatable #6021
Make certain wordings translatable #6021
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6021 +/- ##
=========================================
Coverage 23.59% 23.59%
Complexity 457 457
=========================================
Files 246 246
Lines 11715 11715
Branches 2140 2140
=========================================
Hits 2764 2764
Misses 8637 8637
Partials 314 314
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
36f4778
to
08deb4e
Compare
if (!empty($config->getDescription())) { | ||
$template->addBodyListItem($config->getDescription(), 'Description:'); | ||
$template->addBodyListItem($config->getDescription(), $l10n->t('Description:')); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$template->addBodyListItem($config->getDescription(), $l10n->t('Description:')); | |
$template->addBodyListItem($config->getDescription(), $this->l10n->t('Description:')); |
and for all following usages of $l10n
82e023c
to
4d5c36c
Compare
@@ -194,9 +194,9 @@ public function sendBookingInformationEmail(Booking $booking, AppointmentConfig | |||
$summary = $this->l10n->t('Dear %s, your booking has been accepted.', [$booking->getDisplayName()]); | |||
$template->addHeading($summary); | |||
|
|||
$template->addBodyListItem($user->getDisplayName(), 'Appointment with:'); | |||
$template->addBodyListItem($user->getDisplayName(), $l10n->t('Appointment with:')); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from here …
if (!empty($config->getDescription())) { | ||
$template->addBodyListItem($config->getDescription(), 'Description:'); | ||
$template->addBodyListItem($config->getDescription(), $l10n->t('Description:')); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
… to here you have to replace $l10n with $this->l10n
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ChristophWurst can you check my last commit ?
Tests fail bc the new calls to l10n need to be added. I'll check in a minute and let you know where and how to add these :) |
7aa3883
to
994de8e
Compare
Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com> Make certain wordings translatable Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com> Make certain wordings translatable Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com> Co-Authored-By: Anna <anna@nextcloud.com> Co-Authored-By: Christoph Wurst <ChristophWurst@users.noreply.github.com>
650b175
to
3c97791
Compare
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Just check commit.
Test from reviewers is need.