Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: reduce opacity for past events #6102

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

germelmann
Copy link
Member

@germelmann germelmann commented Jul 2, 2024

fixes #26

Screenshot from 2024-07-02 12-22-12
Screenshot from 2024-07-02 12-21-49

@germelmann germelmann requested a review from GretaD July 2, 2024 10:03
@germelmann germelmann linked an issue Jul 2, 2024 that may be closed by this pull request
@GretaD GretaD added 3 - to review enhancement New feature request labels Jul 2, 2024
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.71%. Comparing base (93374fa) to head (3fa906b).
Report is 6 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6102      +/-   ##
============================================
+ Coverage     24.02%   29.71%   +5.68%     
- Complexity      457      914     +457     
============================================
  Files           246      287      +41     
  Lines         11565    13836    +2271     
  Branches       2153     2164      +11     
============================================
+ Hits           2779     4111    +1332     
- Misses         8472     9410     +938     
- Partials        314      315       +1     
Flag Coverage Δ
javascript 15.56% <ø> (ø)
php 58.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GretaD GretaD changed the title feat: #26 reduce opacitiy for past events feat: reduce opacity for past events Jul 2, 2024
@GretaD GretaD force-pushed the feat/IDofTheIssue/styling-events branch from e1340a2 to 0190385 Compare July 2, 2024 10:24
Copy link
Contributor

@GretaD GretaD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 🥳

Signed-off-by: Peter-J. G. <peter.germelmann@gmail.com>
@germelmann germelmann force-pushed the feat/IDofTheIssue/styling-events branch from 0190385 to 3fa906b Compare July 2, 2024 10:38
@germelmann germelmann merged commit fd312b2 into main Jul 2, 2024
43 checks passed
@germelmann germelmann deleted the feat/IDofTheIssue/styling-events branch July 2, 2024 11:53
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Style past events differently
2 participants