Fix: move state init to a service #6103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miaulalala
requested changes
Jul 2, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6103 +/- ##
============================================
+ Coverage 24.02% 24.08% +0.05%
+ Complexity 457 456 -1
============================================
Files 246 247 +1
Lines 11565 11529 -36
Branches 2153 2152 -1
============================================
- Hits 2779 2777 -2
+ Misses 8472 8438 -34
Partials 314 314
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
miaulalala
reviewed
Jul 2, 2024
miaulalala
reviewed
Jul 2, 2024
| $this->appManager = $appManager; | ||
| $this->compareVersion = $compareVersion; | ||
| $this->userId = $userId; | ||
|
|
miaulalala
reviewed
Jul 2, 2024
miaulalala
reviewed
Jul 2, 2024
Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>
hamza221
force-pushed
the
Fix/intialize-state-correctly
branch
from
732580e
to
eca7d15
Compare
|
/backport to stable4.7 |
backportbot
bot
added
the
backport-request
miaulalala
approved these changes
Jul 3, 2024
2 tasks
backportbot
bot
removed
the
backport-request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix nextcloud/assistant#92 (comment)
Fix #6076