-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to SCSS [was: App to css guidelines] #613
Conversation
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Will these changes be compatible with Nextcloud 11 and 12 too? |
For now compatible 13 only. We'll have to decide if we want to implement a fix until the last supported version is 13. Or something else! :) |
…/bgs Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@georgehrke I added a lots of stuff! Also: please test it under nc12. This pr will allow the app to only nc12 and higher, this is unfortunate but all the other apps are doing the same to enjoy the scss unification! :) |
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
7ef6060
to
c3c6666
Compare
@skjnldsv Is this ready to review? |
@georgehrke sorry, forgot that :p |
@georgehrke I think we're good here. :) |
I created a @skjnldsv You said this works with Nextcloud 12, right? |
No, a specific patch will still be needed. |
Color-picker issue considered unimportant for now. Should be removed in the long run and the new calendar should just be assigned a color that is not in use so far. |
@skjnldsv Can you check this please :) |
Hum, in the end, it could be a good thing to experiment with the color picker on a popover? :) |
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
|
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
…ubscription form Signed-off-by: Georg Ehrke <developer@georgehrke.com>
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
…icon Signed-off-by: Georg Ehrke <developer@georgehrke.com>
f44b3a6
to
7d0dd6d
Compare
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
fd29650
to
a616176
Compare
@skjnldsv @tcitworld I fixed all the issues that i found. Can you double check? :) |
Will have a look this afternoon. |
Amazing work @georgehrke Works perfectly! 😍 🎉 |
@tcitworld Is it okay if i go ahead and merge this? Given the release schedule of the server i would like to get this in fairly soon ;) |
That seems related to this: #571 :) |
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
Fixed. Good to go. |
awesome, let's get this in :) |
Did realize I didn't test this on nc12 though. |
@tcitworld if we want to keep it ok for 12, it's an easy fix :) |
After nextcloud/server#6399