Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update php and nextcloud versions #6147

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

miaulalala
Copy link
Contributor

Needs a follow up for the test matrix as we shouldn't test against stable27 / 28 / 29 any more.

@miaulalala miaulalala added the 3. to review Waiting for reviews label Jul 11, 2024
@miaulalala miaulalala self-assigned this Jul 11, 2024
Copy link

codecov bot commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.97%. Comparing base (bc2cc6d) to head (1917636).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #6147   +/-   ##
=========================================
  Coverage     23.97%   23.97%           
  Complexity      457      457           
=========================================
  Files           247      247           
  Lines         11606    11606           
  Branches       2189     2188    -1     
=========================================
  Hits           2782     2782           
- Misses         8508     8509    +1     
+ Partials        316      315    -1     
Flag Coverage Δ
javascript 15.46% <ø> (ø)
php 59.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make it a feat! commit please because this is a breaking change that warrants a major bump

@miaulalala miaulalala force-pushed the chore/update-app-support-and-php-support branch from 99f2798 to 0d95bdc Compare July 11, 2024 16:35
@miaulalala miaulalala changed the title chore: update php and nextcloud versions feat: update php and nextcloud versions Jul 11, 2024
@st3iny
Copy link
Member

st3iny commented Jul 12, 2024

Composer lock file needs to be updated because of the PHP update (Please run composer update).

Also, I guess you can't move updating the test matrices to another PR because tests will fail here. You should drop all stable* tests here to make CI green.

@miaulalala miaulalala force-pushed the chore/update-app-support-and-php-support branch from 01a8512 to 18ad7d6 Compare July 18, 2024 13:30
Signed-off-by: Anna Larch <anna@nextcloud.com>
@miaulalala miaulalala force-pushed the chore/update-app-support-and-php-support branch from 191b5f5 to 1917636 Compare July 18, 2024 13:52
@miaulalala miaulalala merged commit 0662199 into main Jul 18, 2024
33 checks passed
@miaulalala miaulalala deleted the chore/update-app-support-and-php-support branch July 18, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
Development

Successfully merging this pull request may close these issues.

3 participants