Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Activity registers actions of share and unshare for circles #202

Open
fgsl opened this issue May 14, 2018 · 0 comments
Open

Allow Activity registers actions of share and unshare for circles #202

fgsl opened this issue May 14, 2018 · 0 comments

Comments

@fgsl
Copy link
Contributor

fgsl commented May 14, 2018

Circles does not emit signals to actions of share and unshare, so Activity app does not register these actions.

First I tried to follow same implementation of groups, and submit changes for server and activity projects, but as recommended by @nickvergessen [1] and @rullzer in [2], I will change only Circles app, using part of signals implemented in [3], that is not integrated yet.

[1] nextcloud/activity#269 (comment)
[2] nextcloud/server#9463 (review)
[3] #163

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant