Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow complete inheritance of class ProviderParser #223

Closed
fgsl opened this issue Aug 9, 2018 · 1 comment
Closed

Allow complete inheritance of class ProviderParser #223

fgsl opened this issue Aug 9, 2018 · 1 comment
Assignees
@fgsl
Labels
4. to release

Comments

@fgsl
Copy link
Contributor

fgsl commented Aug 9, 2018

Class ProviderParser has three private methods: setSubject, setRichSubject and setParsedSubject.
If they can be changed to protected, it is possible reuse them in new parser classes.

Motivation is issue #163, that has to be refactored. For refactoring, I will combine #163 with #202, so audit of action will include registering of activities. For that, I am writing a new parser class and I want to avoid repeating code.
@fgsl fgsl self-assigned this Aug 9, 2018
fgsl pushed a commit that referenced this issue Aug 9, 2018
Allow complete inheritance of class ProviderParser #223
15bcfe6
ArtificialOwl added a commit that referenced this issue Sep 5, 2018
@ArtificialOwl
Merge pull request #224 from nextcloud/issue223
415021d 
Allow complete inheritance of class ProviderParser #223
@joshtrichards
Copy link
Member

Fixed in #224

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fgsl fgsl

Labels
4. to release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fgsl @ArtificialOwl @joshtrichards