Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detailed access list #1649

Merged
merged 1 commit into from
Aug 1, 2024
Merged

detailed access list #1649

merged 1 commit into from
Aug 1, 2024

Conversation

ArtificialOwl
Copy link
Member

@ArtificialOwl ArtificialOwl commented Jul 31, 2024

remove an issue while adding comment on a file by fixing getAccessList to returns detailed entries:

with $currentAccess:

[
  'users'  => [
    'user1' => ['node_id' => 42, 'node_path' => '/fileA'],
    'user4' => ['node_id' => 32, 'node_path' => '/folder2'],
    'user2' => ['node_id' => 23, 'node_path' => '/folder (1)'],
  ],
  'remote' => [
    'user1@server1' => ['node_id' => 42, 'token' => 'SeCr3t'],
    'user2@server2' => ['node_id' => 23, 'token' => 'FooBaR'],
  ],
  'public' => bool,
  'mail' => [
    'email1@maildomain1' => ['node_id' => 42, 'token' => 'aBcDeFg'],
    'email2@maildomain2' => ['node_id' => 23, 'token' => 'hIjKlMn'],
  ]
]

without $currentAccess:

[
  'users'  => ['user1', 'user2', 'user4'],
  'remote' => bool,
  'public' => bool
  'mail' => ['email1@maildomain1', 'email2@maildomain2']
]

@ArtificialOwl
Copy link
Member Author

/backport to stable29

@ArtificialOwl
Copy link
Member Author

/backport to stable28

@ArtificialOwl
Copy link
Member Author

/backport to stable27

@ArtificialOwl
Copy link
Member Author

/backport to stable26

@kesselb
Copy link
Contributor

kesselb commented Aug 1, 2024

I rebased the commit locally to 27 for testing and it worked as expected.
Writing a comment now leads to an activity as well when you have access to the file by a circle membership.

lib/ShareByCircleProvider.php Outdated Show resolved Hide resolved
lib/ShareByCircleProvider.php Outdated Show resolved Hide resolved
@ArtificialOwl ArtificialOwl force-pushed the fix/noid/detailed-access-list branch 2 times, most recently from 9500f49 to 4af81ed Compare August 1, 2024 11:01
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
@ArtificialOwl ArtificialOwl merged commit 4bc4086 into master Aug 1, 2024
29 checks passed
@kesselb kesselb deleted the fix/noid/detailed-access-list branch August 1, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants