Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(notifications): Don't trigger invite notifications for system groups #1650

Merged
merged 1 commit into from
Jul 31, 2024
Merged

fix(notifications): Don't trigger invite notifications for system groups #1650

merged 1 commit into from
Jul 31, 2024

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Jul 31, 2024 •
edited
Loading

Regression from #1641

Before

Adding a user to a system group triggers a notification:

You have been invited by Circles into the Circle "group1"

After

🧹

@nickvergessen
fix(notifications): Don't trigger invite notifications for system groups
c90b2d9 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added this to the Nextcloud 30 milestone Jul 31, 2024
@nickvergessen nickvergessen self-assigned this Jul 31, 2024
This was referenced Jul 31, 2024
Merged
Merged
Merged
kesselb
kesselb approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@kesselb kesselb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

Sorry, I should have used an own event listener right away to avoid conflicts.

@nickvergessen nickvergessen merged commit 14b9cd6 into master Jul 31, 2024
21 checks passed
@nickvergessen nickvergessen deleted the followup/1641/dont-invite-for-system-groups branch July 31, 2024 09:33
@kesselb
Copy link
Contributor

kesselb commented Jul 31, 2024

/backport to stable29

@kesselb
Copy link
Contributor

kesselb commented Jul 31, 2024

/backport to stable28

@backportbot backportbot bot mentioned this pull request Jul 31, 2024
Merged
@kesselb
Copy link
Contributor

kesselb commented Jul 31, 2024

/backport to stable27

This was referenced Jul 31, 2024
Merged
Merged
@blizzz blizzz mentioned this pull request Aug 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kesselb kesselb kesselb approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl

Assignees

@nickvergessen nickvergessen

Labels
3. to review bug
Projects
None yet
Milestone
Nextcloud 30
Development

Successfully merging this pull request may close these issues.
2 participants
@nickvergessen @kesselb