refactor: Migrate away from deprecated ILogger to PSR-3
#1674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mostly replace `ILogger` with `LoggerInterface` and some minor cleanup (constructor property promotion). Some places used the deprecated `logException`, this is easy to migrate: Simply use the appropriate log level on the logger and place the exception under the `exception` key in the context. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
come-nc
reviewed
Aug 19, 2024
| @@ -98,7 +97,7 @@ public function __construct( | |||
| IUserManager $userManager, | |||
| IRootFolder $rootFolder, | |||
| IL10N $l10n, | |||
| ILogger $logger, | |||
| mixed $logger, // unused, only kept for compatibility with server | |||
There was a problem hiding this comment.
Damn this is ugly.
Server should use DI and the app should register the service if needed.
There was a problem hiding this comment.
Yes I know but there are also other parameters where this is already done 😔
There was a problem hiding this comment.
But server already checks class_exists, meaning it can be auto-loaded, so we should theoretically be able to simply DI in server.
come-nc
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly replace
ILoggerwithLoggerInterfaceand some minor cleanup (constructor property promotion).Some places used the deprecated
logException, this is easy to migrate: Simply use the appropriate log level on the logger and place the exception under theexceptionkey in the context.