Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OCI ci and make tests not silently failing #900

Merged
merged 6 commits into from
Mar 28, 2022
Merged

Add OCI ci and make tests not silently failing #900

merged 6 commits into from
Mar 28, 2022

Conversation

CarlSchwan
Copy link
Member

No description provided.

@CarlSchwan CarlSchwan marked this pull request as draft January 11, 2022 16:09
@CarlSchwan CarlSchwan force-pushed the ci/add-oracle branch 2 times, most recently from 8381fd7 to a210765 Compare January 12, 2022 12:53
@CarlSchwan CarlSchwan changed the title Add OCI ci Add OCI ci and make tests not silently failing Jan 12, 2022
@CarlSchwan CarlSchwan marked this pull request as ready for review January 12, 2022 13:07
@ArtificialOwl
Copy link
Member

  • verify that Oracle create/migrate database correctly

@CarlSchwan
Copy link
Member Author

@ArtificialOwl I ended up disabling the Api tests as they need way too much adaption. I guess they need to be ported away from the Circles v1 API to the CirclesManager

The Controller tests now are running again and are passing the ci and it's better than nothing :)

@ArtificialOwl
Copy link
Member

Issue on php7.40-oci seems to come from the fact some some SQL table field names/aliases are longer than 30 chars

@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@c3012fc). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 473909e differs from pull request most recent head 583af2a. Consider uploading reports for the commit 583af2a to get more accurate results

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #900   +/-   ##
========================================
  Coverage          ?   0.70%           
  Complexity        ?    5688           
========================================
  Files             ?     289           
  Lines             ?   19686           
  Branches          ?       0           
========================================
  Hits              ?     138           
  Misses            ?   19548           
  Partials          ?       0

@ArtificialOwl
Copy link
Member

rebased

@CarlSchwan
Copy link
Member Author

And now nextcloud/server#31513 is blocking the CI :(

@ArtificialOwl
Copy link
Member

I will work on this, but won't be backported for next minor release

@ArtificialOwl ArtificialOwl force-pushed the ci/add-oracle branch 2 times, most recently from c3eb26c to a3ec019 Compare March 18, 2022 11:24
@ArtificialOwl
Copy link
Member

rebased, adding a condition that there is no primarykey before creation.

@tcitworld tcitworld mentioned this pull request Mar 18, 2022
Closed
5 tasks
@ArtificialOwl
Copy link
Member

/backport to stable23

@ArtificialOwl
Copy link
Member

/backport to stable22

@CarlSchwan
Add OCI ci
718fb3d 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
CarlSchwan and others added 5 commits March 28, 2022 10:32
@CarlSchwan
Add debug output
c1c41c7 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
@CarlSchwan
Fix silently failing tests
e403c36 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
@CarlSchwan
Fix the Controller tests and disabled the api tests
83ac8b0 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
@ArtificialOwl @CarlSchwan
shorten aliases
b520fcb 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
@ArtificialOwl @CarlSchwan
primaryKey on circles_membership
583af2a 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
@CarlSchwan CarlSchwan merged commit 69c2f79 into master Mar 28, 2022
@delete-merged-branch delete-merged-branch bot deleted the ci/add-oracle branch March 28, 2022 08:41
@backportbot-nextcloud
Copy link

The backport to stable23 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

The backport to stable22 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

The backport to stable23 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

The backport to stable22 failed. Please do this backport manually.

This was referenced Mar 28, 2022
Closed
Merged
Merged
@blizzz blizzz mentioned this pull request Mar 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArtificialOwl ArtificialOwl ArtificialOwl approved these changes

Assignees
No one assigned
Labels
backport-request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CarlSchwan @ArtificialOwl @codecov-commenter