-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bypass/limit permissions #976
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
ArtificialOwl
force-pushed
the
enh/noid/limit-circle-creation
branch
from
March 28, 2022 12:14
8959299
to
57e0006
Compare
ArtificialOwl
requested review from
mejo- and
CarlSchwan
and removed request for
mejo-
March 28, 2022 12:16
ArtificialOwl
force-pushed
the
enh/noid/limit-circle-creation
branch
3 times, most recently
from
March 31, 2022 20:31
f1df488
to
211f585
Compare
Codecov Report
@@ Coverage Diff @@
## master #976 +/- ##
========================================
Coverage 0.69% 0.70%
- Complexity 5716 5735 +19
========================================
Files 289 290 +1
Lines 19766 19822 +56
========================================
+ Hits 138 139 +1
- Misses 19628 19683 +55
Continue to review full report at Codecov.
|
CarlSchwan
reviewed
Apr 1, 2022
ArtificialOwl
force-pushed
the
enh/noid/limit-circle-creation
branch
2 times, most recently
from
April 4, 2022 12:13
aaa5e7d
to
c50d85e
Compare
squashed, rebased |
ArtificialOwl
force-pushed
the
enh/noid/limit-circle-creation
branch
from
April 5, 2022 11:34
c50d85e
to
3d912bf
Compare
mejo-
approved these changes
Apr 6, 2022
Signed-off-by: Maxence Lange <maxence@artificial-owl.com> Co-authored-by: Carl Schwan <carl@carlschwan.eu>
ArtificialOwl
force-pushed
the
enh/noid/limit-circle-creation
branch
from
April 6, 2022 15:56
3d912bf
to
d6544d4
Compare
/backport to stable23 |
/backport to stable22 |
This was referenced Apr 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(replacement for #975)
This PR allow to assign different entities to limit/bypass some permissions. Each settings is defined by a singleId. Only members (and inherited) that belongs to the Entity defined by its singleId will be affected:
circle_types_block
andcircle_types_force