Use linuxdeployqt

[probonopd]

Work-in-progress for using linuxdeployqt. Please only merge once we have a known good AppImage.

[enoch85]

Not using 5.8?

[TheAssassin]

Why do you think so? It says qt58.

[probonopd]

linuxdeployqt should take care of the Qt plugins automatically

[enoch85]

Great!

@TheAssassin 58 is 5.8 without a dot. That's why.

[enoch85]

I'll leave the merge to you guys or when you approved this.

[TheAssassin]

I'll test it thoroughly tomorrow morning, and will post feedback.

[TheAssassin]

https://travis-ci.org/nextcloud/client_theming/jobs/251359362#L2256-L2281
There are several problems with this PR, it does not produce a working AppImage. There's a wrong CMake command, and appimagetool shows this $ID.desktop file not found message that I thought we had fixed.

[TheAssassin]

This can't work for obvious reasons.

[probonopd]

It is really annoying me that errors still result in a green Travis CI result. Something seems to ignore exit codes...

[TheAssassin]

@probonopd try adding set -e somewhere near the top.

[probonopd]

Somehow I have the feeling that my edited linux/AppImage/build-appimage.sh isn't even what is being run... Clues, anyone?

[TheAssassin]

The original script is called appimage-build.sh. Yours is called differently. You'd have to remove the other one and rename yours, or edit the Travis configuration.

[probonopd]

So indeed, I think the whole way how Travis is invoked is messy (distributed over several files) which makes it hard to see immediately what is going on.

[enoch85]

What's the status here?

[TheAssassin]

So indeed, I think the whole way how Travis is invoked is messy (distributed over several files) which makes it hard to see immediately what is going on.

@probonopd while this might be true, it also means that your way of developing this feature (i.e. using the GitHub editor and Travis) doesn't work here. You might want to think about developing this feature locally.

@enoch85 @probonopd has been busy recently. It's still on track as far as I can tell.

[rullzer]

@probonopd thnx a lot. However this AppImage doesn't work for me. It can't load the libnextcloudsync.so it seems the rpath for the binary does not contain it.

Same goes actually for the rpath of the libs (so if you look at the rpath of libnextcloudsync.so it can't find the libqtkeychain.so etc).

[probonopd]

Have quite some extras to do just because the libnextcloud* is installed into a subdirectory of the libraries directory. Makes it much harder than necessary. What is the reason for the subdirectory?

[probonopd]

@rullzer please try again. https://transfer.sh/uAeVm/Nextcloud-2.3.2-beta-x86_64.AppImage works for me now.

EDIT: Link corrected.

[enoch85]

https://transfer.sh/uAeVm/Nextcloud-2.3.2-beta-x86_64.AppImageAppImage works for me now.

404

[TheAssassin]

@enoch85 Try https://transfer.sh/uAeVm/Nextcloud-2.3.2-beta-x86_64.AppImage, the second "AppImage" is not necessary.

[enoch85]

Aah that's better :)

[TheAssassin]

It's called "common sense", you can get it in your local convenience store.

[enoch85]

Didn't read, just clicked, but yeah you're right.

[TheAssassin]

Never mind, we've all been there.

[TheAssassin]

I'd love to see the switch to linuxdeployqt, better sooner than later. This project is still using the deprecated functions.sh stuff. linuxdeployqt is really a superior solution, much cleaner, and probably faster.