Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule proposal single_quote #23

Closed
nickvergessen opened this issue Jul 31, 2024 · 3 comments · Fixed by #25
Closed

Rule proposal single_quote #23

nickvergessen opened this issue Jul 31, 2024 · 3 comments · Fixed by #25

Comments

@nickvergessen
Copy link
Member

Ref https://cs.symfony.com/doc/rules/string_notation/single_quote.html

I'd like to introduce it with the default value:

--- Original
+++ New
 <?php

-$a = "sample";
+$a = 'sample';
 $b = "sample with 'single-quotes'";
@ChristophWurst
Copy link
Member

What happens to string with variables like "hello $name"?

@nickvergessen
Copy link
Member Author

It's good:
grafik

Same for \n:
grafik

@ChristophWurst
Copy link
Member

Then 👍 fine by me

kesselb added a commit that referenced this issue Aug 23, 2024
#23

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants