Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rule proposal for "cast" #24

Closed
nickvergessen opened this issue Aug 23, 2024 · 5 comments · Fixed by #25
Closed

Rule proposal for "cast" #24

nickvergessen opened this issue Aug 23, 2024 · 5 comments · Fixed by #25

Comments

@nickvergessen
Copy link
Member

I'd like to propose:
@ChristophWurst
Copy link
Member

👍 from me

kesselb added a commit that referenced this issue Aug 23, 2024
@kesselb
style: add rules for casts
f8e84b5 
#24

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselb kesselb mentioned this issue Aug 23, 2024
Merged
@kesselb
Copy link
Contributor

kesselb commented Aug 23, 2024

cast_spaces: ['single']

I usually omit the extra space because the cast and variable belongs together, however the diff output is much nicer and the cast easier to spot with a space between 👍

400 files changed in server.

lowercase_cast

0 files changed in server 🙌

no_short_bool_cast

2 files changed in server.

short_scalar_cast

1 file changed in server.

Pull Request: #25

@nickvergessen
Copy link
Member Author

400 files changed in server.

Is it much better if we opt for cast_spaces: ['none']

@kesselb
Copy link
Contributor

kesselb commented Aug 23, 2024

180 for none

@nickvergessen
Copy link
Member Author

I'm fine both ways

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

style: add rules for casts / single quotes nextcloud/coding-standard
3 participants
@nickvergessen @ChristophWurst @kesselb