feat: Add blank lines before returns and after control statements #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: provokateurin <kate@provokateurin.de>
provokateurin
requested review from
nickvergessen,
ChristophWurst,
kesselb,
skjnldsv and
come-nc
Base automatically changed from
enh/break-promoted-properties-on-multiline
to
master
September 18, 2024 11:16
ChristophWurst
dismissed
kesselb’s stale review
The base branch was changed.
ChristophWurst
approved these changes
Sep 18, 2024
kesselb
approved these changes
Sep 18, 2024
skjnldsv
approved these changes
Sep 18, 2024
provokateurin
changed the title
|
I kind of disagree with this. it forces a lot of empty lines into code and can actually reduce the readability? |
|
Agree after seeing this in action 💔 |
|
In Talk it would add 997 new lines 😱 |
For personally not, as I always write my code with these newlines, but sure don't need to force everyone to have this style. |
approval under influence |
|
I didn't even look to your table xD |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #31 to avoid conflicts.
See
https://github.com/erickskrauch/php-cs-fixer-custom-fixers?tab=readme-ov-file#erickskrauchblank_line_before_return
and
https://github.com/erickskrauch/php-cs-fixer-custom-fixers?tab=readme-ov-file#erickskrauchline_break_after_statements.