-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use php-cs-fixer ^3.2 #7
Conversation
Signed-off-by: dartcafe <github@dartcafe.de>
89c3aeb
to
8a61acc
Compare
Signed-off-by: dartcafe <github@dartcafe.de>
fb76775
to
8f65365
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot. Will give this a test soon :)
Signed-off-by: dartcafe <github@dartcafe.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with Mail and works 🚀
'list_syntax' => [ | ||
'syntax' => 'short', | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was this intentional? It's this here, right:
list($a, $b) = …;
[$a, $b] = …;
I don't think we want to go back and allow the long one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't catch this but no, I would not go back. Could you send a PR to fix it? We can do a v1.0.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or is this rule not supported anymore and "short" by default now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR in #8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed it, because it is declared as default in 3.2.
From https://github.com/FriendsOfPHP/PHP-CS-Fixer/blob/v3.0.0/UPGRADE-v3.md
Changed default values of options
Rule | Option | Old value | New value |
---|---|---|---|
list_syntax |
syntax |
'long' |
'short' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fancy, sorry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to know, that someone does a real review...
first try
fixes #6
Since v3 brings some breaking changes, I guess, it should be a major version update.
Also some remarks are recommended:
.gitignore
:.php-cs-fixer.cache