Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Addressbook" section in contact details not necessary if there is only one address book #1065

Closed
jancborchardt opened this issue Apr 18, 2019 · 1 comment · Fixed by #1074
Closed

"Addressbook" section in contact details not necessary if there is only one address book #1065

jancborchardt opened this issue Apr 18, 2019 · 1 comment · Fixed by #1074
Labels
1. to develop Accepted and waiting to be taken care of design Related to the design enhancement New feature or request

Comments

@jancborchardt
Copy link
Member

jancborchardt commented Apr 18, 2019 •
edited by jospoortvliet
Loading

The concept of an "address book" that contacts are stored in is quite technical. The default is only having one address book, and in that case the section in the contact details is greyed out anyway:
Addressbook

Since it is not relevant in this case, we don’t need to show it at all. cc @nextcloud/contacts
@jancborchardt jancborchardt added enhancement New feature or request 1. to develop Accepted and waiting to be taken care of design Related to the design labels Apr 18, 2019
@skjnldsv
Copy link
Member

I guess yes X) 👍

@skjnldsv skjnldsv mentioned this issue Apr 26, 2019
Merged
skjnldsv added a commit that referenced this issue Apr 26, 2019
@skjnldsv
Fix alignment and remove addressbook selector if only one (#1074)
8170395 
Fix #1065
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1. to develop Accepted and waiting to be taken care of design Related to the design enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix alignment and remove addressbook selector if only one nextcloud/contacts
2 participants
@jancborchardt @skjnldsv