Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contact deletion management (trash bin, undo) #296

Open
1 of 2 tasks
skjnldsv opened this issue Aug 22, 2017 · 13 comments
Open
1 of 2 tasks

Contact deletion management (trash bin, undo) #296

skjnldsv opened this issue Aug 22, 2017 · 13 comments
Labels
1. to develop Accepted and waiting to be taken care of enhancement New feature or request high High priority

Comments

@skjnldsv
Copy link
Member

skjnldsv commented Aug 22, 2017

Two options (cumulable):

  • A trashbin to restore deleted contacts (local save)
  • An undo button

https://www.npmjs.com/package/store


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@skjnldsv skjnldsv added 1. to develop Accepted and waiting to be taken care of enhancement New feature or request high High priority labels Aug 22, 2017
@skjnldsv skjnldsv added this to the 2.1.0 milestone Aug 22, 2017
@skjnldsv skjnldsv self-assigned this Aug 22, 2017
@frogueat
Copy link

Nice would also be the posibility, to delete many contacts at once. Eg when imported something via vcf and the data is wrong ... Maybe a whole group?

@skjnldsv
Copy link
Member Author

skjnldsv commented Aug 24, 2017

@frogueat Not the same issue, see #277

@MariusBluem
Copy link
Member

In the same way as in the calendar app 🙈

@fgarcia78
Copy link

When there is more than one addressbook and the user deletes one of them (by clicking the trash button), the UI doesn't confirm that action and all contacts in such addressbook get wiped; furthermore, the UI does not visually reflect the deletion and keeps showing those contacts in the list (cache?).

I don't know if this is addressed elsewhere, I'm in 1.5.3.

@skjnldsv
Copy link
Member Author

@fgarcia78 This has literaly nothing to do with that issue! 😕
Lucky for you, this issue had already been fixed and will be on the next release. See #288 .

@fgarcia78
Copy link

@skjnldsv - yeah, I see now my error... altough the ticket name is misleading: "Contact deletion management" sounds too broad and this enhancement refers to "Contact un-deletion management"!! 😄

@Jas2Ma
Copy link

Jas2Ma commented Jan 21, 2018

Add nextcloud activity events for contacts, so deletion of a contact can be recognized by other users of the address book.

@tdoerschel
Copy link

tdoerschel commented Jan 8, 2019

I agree that the risk of accidentelly deleting a contact or a field is very high: The delete buttons are all over the webpage.

A confirmation popup ("Are you sure?"), trashbin or undo (for 3 seconds) would ease one's mind.

@skjnldsv skjnldsv mentioned this issue Jan 25, 2019
@tdoerschel
Copy link

Feature has been implemented for contact delete in version 3.1.0

Can you also also do it for the field delete buttons?

@ChristophWurst ChristophWurst removed this from the next minor milestone Sep 14, 2021
@mejo-
Copy link
Member

mejo- commented May 4, 2023

Given that delete undo is implemented now, this issue can be closed, no? Or am I missing anything @skjnldsv?

@PhilippSchlesinger
Copy link

@mejo- could you maybe give a hint (or even some screenshot) how this feature got implemented in the meantime? Did I really miss that out? When I delete a contact, I is simply gone. There is no undo dialog and no trashbin to restore from.
(Contacts 5.2.0 on Nextcloud 25.0.6)

Thank you.

@mejo-
Copy link
Member

mejo- commented May 5, 2023

Sorry, I got confused. You're right and there's no delete undo implemented yet. Sorry for the noise 🙈

@joshtrichards
Copy link
Member

Sorry, I got confused. You're right and there's no delete undo implemented yet. Sorry for the noise 🙈

To be fair, there used to be. #1025

@joshtrichards joshtrichards changed the title Contact deletion management Contact deletion management (trash bin, undo) Jun 15, 2024
@skjnldsv skjnldsv removed their assignment Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of enhancement New feature or request high High priority
Projects
None yet
Development

No branches or pull requests

10 participants